Sheffield | 26-ITP-Jan | Mona-Eltantawy | Sprint 3| Alarm clock#1158
Open
Mona-Eltantawy wants to merge 7 commits intoCodeYourFuture:mainfrom
Open
Sheffield | 26-ITP-Jan | Mona-Eltantawy | Sprint 3| Alarm clock#1158Mona-Eltantawy wants to merge 7 commits intoCodeYourFuture:mainfrom
Mona-Eltantawy wants to merge 7 commits intoCodeYourFuture:mainfrom
Conversation
… instead of number - in the js file i implemented functions to set the alarm to count the remaining time and play the alarm sound when it counts to 0 .
Mona-Eltantawy
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
bot
removed
the
Needs Review
This comment has been minimized.
This comment has been minimized.
Mona-Eltantawy
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
bot
removed
the
Needs Review
Mona-Eltantawy
added
the
Needs Review
Luro91
added
Review in progress
Luro91
reviewed
Apr 4, 2026
There was a problem hiding this comment.
The html title should say "Alarm clock app"
There was a problem hiding this comment.
I meant the title that is responsible for what is shown in the tab in the browser header. How can you change this?
| function setAlarm() {} | ||
| var audio = new Audio("alarmsound.mp3"); | ||
|
|
||
| // DO NOT EDIT BELOW HERE |
There was a problem hiding this comment.
I think your code should be above this line
Author
There was a problem hiding this comment.
I changed the whole page multiple times so I don't have the line now
Comment on lines
+11
to
+12
| if (isNaN(timeRemaining) || timeRemaining <= 0) { | ||
| alert("Please enter a valid number greater than 0"); |
There was a problem hiding this comment.
Nice error handling. It's important to validate user input
Author
There was a problem hiding this comment.
I've changed the alert to console.error.
not sure if it's right or not.
There was a problem hiding this comment.
I did not intent to request a change here. It was already good. The advantage of the alert is that it is more visible to the user. For the first exercises I think alerts and console.error logs are both fine.
|
|
||
| function pauseAlarm() { | ||
| audio.pause(); | ||
| audio.currentTime = 0; |
Luro91
added
Reviewed
Mona-Eltantawy
added
the
Needs Review
Luro91
removed
the
Needs Review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist