Skip to content

West Midlands | Gabriel Deng | Sprint 1 | Can't log in from profile page #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gai93003 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

West Midlands | Gabriel Deng | Sprint 1 | Can't log in from profile page #48

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
df65e18
This is the solution for the login error
gai93003 Nov 5, 2025
2389026
Add a line to ensure that the user is redirected to the homepage afte…
gai93003 Nov 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions front-end/lib/api.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,6 +138,7 @@ async function signup(username, password) {

function logout() {
state.destroyState();
window.location.hash = "/";
Copy link
Member

@illicitonion illicitonion Jan 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about this part of the change - if the profile page works when logged out, why do we want to take someone away from it when they log out? (I can argue this either way - I'm interested in your thoughts here)

return {success: true};
}

Expand Down
5 changes: 3 additions & 2 deletions front-end/views/profile.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,10 @@ function profileView(username) {
"login-template",
createLogin
);

document
.querySelector("[data-action='login']")
?.addEventListener("click", handleLogin);
.querySelector("[data-form='login']")
?.addEventListener("submit", handleLogin);

const profileData = state.profiles.find((p) => p.username === username);
if (profileData) {
Expand Down