Skip to content

Glasgow | 25-SDC-NOV | Katarzyna Kazimierczuk | Sprint 4 | Python shell tools#331

Closed
katarzynakaz wants to merge 6 commits into
CodeYourFuture:mainfrom
katarzynakaz:python-shell-tools
Closed

Glasgow | 25-SDC-NOV | Katarzyna Kazimierczuk | Sprint 4 | Python shell tools#331
katarzynakaz wants to merge 6 commits into
CodeYourFuture:mainfrom
katarzynakaz:python-shell-tools

Conversation

@katarzynakaz

@katarzynakaz katarzynakaz commented Feb 22, 2026

Copy link
Copy Markdown

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

Cat, wc and ls implemented in pyton.

@katarzynakaz katarzynakaz added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. 📅 Sprint 4 Assigned during Sprint 4 of this module labels Feb 22, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 22, 2026
@github-actions

This comment has been minimized.

Sign in to view
1 similar comment
@github-actions

This comment has been minimized.

Sign in to view
@katarzynakaz katarzynakaz added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. NotCoursework labels Feb 22, 2026
@OracPrime OracPrime added the Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. label Feb 28, 2026
OracPrime
OracPrime suggested changes Feb 28, 2026
View reviewed changes

@OracPrime OracPrime left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some significant cleaning up needed on this one.

Comment thread implement-shell-tools/cat/cat.py Outdated
Comment thread implement-shell-tools/cat/cat.py
Comment thread implement-shell-tools/cat/cat.py Outdated
Comment thread implement-shell-tools/cat/cat.py Outdated
Comment thread implement-shell-tools/ls/ls.py Outdated
Comment thread implement-shell-tools/ls/ls.py Outdated
Comment thread implement-shell-tools/wc/wc.py Outdated
Comment thread implement-shell-tools/wc/wc.py Outdated
Comment thread implement-shell-tools/wc/wc.py Outdated
Comment thread number-systems/README.md Outdated
@OracPrime OracPrime added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Feb 28, 2026
@OracPrime

OracPrime commented Feb 28, 2026

Copy link
Copy Markdown

I also don't understand why this has the "NotCoursework" tag - it's in the backlog

@katarzynakaz katarzynakaz added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed NotCoursework labels Mar 2, 2026
@github-actions

This comment has been minimized.

Sign in to view
1 similar comment
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 2, 2026
OracPrime
OracPrime suggested changes Mar 2, 2026
View reviewed changes

@OracPrime OracPrime left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more file to remove

Comment thread number-systems/README.md
The goal of these exercises is for you to gain an intuition for binary numbers. Using tools to solve the problems defeats the point.

Convert the decimal number 14 to binary.
Answer:

@OracPrime OracPrime Mar 2, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is not part of this sprint. You need to do a git restore of the file to get it back to the original state

@katarzynakaz katarzynakaz Mar 3, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue fixed

@OracPrime OracPrime Mar 4, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Github doesn't agree. It is showing differences. If you do a restore to the start point of thie PR then this file shouldn't be showing up in the PR list at all.

@katarzynakaz katarzynakaz Mar 4, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you, that's now done

@katarzynakaz katarzynakaz added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 3, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 3, 2026
OracPrime
OracPrime suggested changes Mar 4, 2026
View reviewed changes

@OracPrime OracPrime left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not quite there yet.

Comment thread number-systems/README.md
The goal of these exercises is for you to gain an intuition for binary numbers. Using tools to solve the problems defeats the point.

Convert the decimal number 14 to binary.
Answer:

@OracPrime OracPrime Mar 4, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Github doesn't agree. It is showing differences. If you do a restore to the start point of thie PR then this file shouldn't be showing up in the PR list at all.

@katarzynakaz katarzynakaz added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 4, 2026
OracPrime
OracPrime approved these changes Mar 4, 2026
View reviewed changes

@OracPrime OracPrime left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorted!

@OracPrime OracPrime added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Mar 4, 2026
@illicitonion

illicitonion commented Jun 30, 2026

Copy link
Copy Markdown
Member

Closing PR because the SDC run has finished. Feel free to re-open if you're still working on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@OracPrime OracPrime OracPrime approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed. Reviewed Volunteer to add when completing a review with trainee action still to take. 📅 Sprint 4 Assigned during Sprint 4 of this module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@katarzynakaz @OracPrime @illicitonion