Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
This refactors evalbuff's docs-selection loop to gate each candidate docs change against the originating carving task instead of accepting all docs updates.
It also moves docs planning to a single per-task docs-writer pass that:
The branch also includes Bun env preloading so live tests pick up
.env.localautomatically, plus new unit and real-agent E2E coverage for the docs writer.Why
The previous flow accepted docs changes too eagerly and did not separate reusable improvements from task-specific overfitting. It also paid a high token cost by rereading docs for each suggestion.
This change makes docs acceptance measurable per task, pushes overfitting decisions into the docs writer, and reduces docs-writer context cost by planning all candidate changes in one pass.
Impact
.env.local/.envValidation
bun test src/__tests__/docs-writer.test.tsbun run typecheckbun run testbun test src/__tests__/docs-writer.e2e.test.tsRoot cause
Docs updates were being selected without a task-local gate and without a reusable/overfit decision point. The docs writer also incurred unnecessary token cost by re-reading the repository docs for every individual suggestion.