fix: redact check console repository path#117
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Redacts secret-like values from the
checkconsole repository path header.Why
The console output path for
checkwas the only supported output path that printed the repository path without passing throughredact_secret_like_values, which contradicted the documented redaction boundary.Scope
Checks
./scripts/check.shpassed locally with 153 testsSecurity and boundary impact
This touches supported output redaction. It does not add network behavior, LLM behavior, command execution, dependencies, release changes, tag changes, or PyPI changes.
Known limitations
None for this focused fix.