Conversation
Bumps [Codeuctivity.SkiaSharpCompare](https://github.com/Codeuctivity/SkiaSharp.Compare) from 2.0.159 to 2.1.185. - [Release notes](https://github.com/Codeuctivity/SkiaSharp.Compare/releases) - [Commits](Codeuctivity/SkiaSharp.Compare@2.0.159...2.1.185) --- updated-dependencies: - dependency-name: Codeuctivity.SkiaSharpCompare dependency-version: 2.1.185 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
…ty.SkiaSharpCompare-2.1.185 Bump Codeuctivity.SkiaSharpCompare from 2.0.159 to 2.1.185
Bumps Codeuctivity.HtmlRenderer to 4.0.458 Bumps Microsoft.NET.ILLink.Tasks from 8.0.15 to 8.0.18 Bumps Swashbuckle.AspNetCore from 8.1.1 to 9.0.3 --- updated-dependencies: - dependency-name: Codeuctivity.HtmlRenderer dependency-version: 4.0.458 dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: Codeuctivity.HtmlRenderer dependency-version: 4.0.458 dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: Microsoft.NET.ILLink.Tasks dependency-version: 8.0.18 dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: Swashbuckle.AspNetCore dependency-version: 9.0.3 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
…tmlCli/multi-06a1b6931f Bump Codeuctivity.HtmlRenderer and 2 others
--- updated-dependencies: - dependency-name: Codeuctivity.OpenXmlPowerTools dependency-version: 8.0.369 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
…tml/Codeuctivity.OpenXmlPowerTools-8.0.369 Bump Codeuctivity.OpenXmlPowerTools from 8.0.314 to 8.0.369
Bumps Codeuctivity.OpenXmlPowerTools from 8.0.369 to 8.0.374 Bumps Microsoft.NET.ILLink.Tasks from 8.0.18 to 8.0.19 --- updated-dependencies: - dependency-name: Codeuctivity.OpenXmlPowerTools dependency-version: 8.0.374 dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: Microsoft.NET.ILLink.Tasks dependency-version: 8.0.19 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
…tml/multi-f00fcca230 Bump Codeuctivity.OpenXmlPowerTools and Microsoft.NET.ILLink.Tasks
…y class documentation
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Bumps [actions/checkout](https://github.com/actions/checkout) from 4 to 5. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v4...v5) --- updated-dependencies: - dependency-name: actions/checkout dependency-version: '5' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
…ctions/checkout-5 Bump actions/checkout from 4 to 5
--- updated-dependencies: - dependency-name: Swashbuckle.AspNetCore dependency-version: 9.0.4 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [actions/setup-dotnet](https://github.com/actions/setup-dotnet) from 4 to 5. - [Release notes](https://github.com/actions/setup-dotnet/releases) - [Commits](actions/setup-dotnet@v4...v5) --- updated-dependencies: - dependency-name: actions/setup-dotnet dependency-version: '5' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [actions/stale](https://github.com/actions/stale) from 9 to 10. - [Release notes](https://github.com/actions/stale/releases) - [Changelog](https://github.com/actions/stale/blob/main/CHANGELOG.md) - [Commits](actions/stale@v9...v10) --- updated-dependencies: - dependency-name: actions/stale dependency-version: '10' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
…ctions/setup-dotnet-5 Bump actions/setup-dotnet from 4 to 5
…ctions/stale-10 Bump actions/stale from 9 to 10
…tmlOpenApi/Swashbuckle.AspNetCore-9.0.4 Bump Swashbuckle.AspNetCore from 9.0.3 to 9.0.4
--- updated-dependencies: - dependency-name: Codeuctivity.SkiaSharpCompare dependency-version: 2.1.202 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
…tmlTests/Codeuctivity.SkiaSharpCompare-2.1.202 Bump Codeuctivity.SkiaSharpCompare from 2.1.185 to 2.1.202
--- updated-dependencies: - dependency-name: Swashbuckle.AspNetCore dependency-version: 9.0.5 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
…tmlOpenApi/Swashbuckle.AspNetCore-9.0.5 Bump Swashbuckle.AspNetCore from 9.0.4 to 9.0.5
--- updated-dependencies: - dependency-name: Swashbuckle.AspNetCore dependency-version: 9.0.6 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
…tmlOpenApi/Swashbuckle.AspNetCore-9.0.6 Bump Swashbuckle.AspNetCore from 9.0.5 to 9.0.6
--- updated-dependencies: - dependency-name: Codeuctivity.OpenXmlPowerTools dependency-version: 9.0.416 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
…tml/Codeuctivity.OpenXmlPowerTools-9.0.416 Bump Codeuctivity.OpenXmlPowerTools from 9.0.385 to 9.0.416
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the Codeuctivity.OpenXmlPowerTools package to version 9.0.416 and includes several related dependency updates and code improvements.
- Updates multiple package dependencies to newer versions
- Migrates from SixLabors.ImageSharp to SkiaSharp for image processing
- Adds better error handling and documentation improvements
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| OpenXmlToHtml/OpenXmlToHtml.csproj | Updates main package to version 9.0.416 and SonarAnalyzer |
| OpenXmlToHtmlTests/OpenXmlToHtmlTests.csproj | Updates test dependencies including HtmlRenderer and test frameworks |
| OpenXmlToHtmlTests/OpenXmlToHtmlIntegrationTests.cs | Migrates from ImageSharp to SkiaSharp for bitmap validation |
| OpenXmlToHtmlOpenApiTests/OpenXmlToHtmlOpenApiTests.csproj | Updates test dependencies for API tests |
| OpenXmlToHtmlOpenApi/OpenXmlToHtmlOpenApi.csproj | Updates HtmlRenderer and Swashbuckle packages |
| OpenXmlToHtmlCli/Program.cs | Makes Program class static |
| OpenXmlToHtmlCli/OpenXmlToHtmlCli.csproj | Updates SonarAnalyzer and adds ILLink package |
| OpenXmlToHtml/Tooling/Linux.cs | Adds documentation and improves error handling |
| OpenXmlToHtml/ExportImageHandler.cs | Adds null checking and improves alt text handling |
| .vscode/settings.json | Adds test discovery configuration |
| .github/workflows/stale.yml | Updates stale action version |
| .github/workflows/dotnet.yml | Updates GitHub Actions and removes Azure deployment |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| var cidReference = $"cid: {cid}"; | ||
|
|
||
| return new XElement(Xhtml.img, new XAttribute(NoNamespace.src, cidReference), imageInfo.ImgStyleAttribute, imageInfo?.AltText != null ? new XAttribute(NoNamespace.alt, imageInfo.AltText) : null); | ||
| return new XElement(Xhtml.img, new XAttribute(NoNamespace.src, cidReference), imageInfo.ImgStyleAttribute, !string.IsNullOrEmpty(imageInfo.AltText) ? new XAttribute(NoNamespace.alt, imageInfo.AltText) : null); |
There was a problem hiding this comment.
[nitpick] This line is too long and complex. Consider breaking it into multiple lines or extracting the conditional attribute creation into a variable for better readability.
Suggested change
| return new XElement(Xhtml.img, new XAttribute(NoNamespace.src, cidReference), imageInfo.ImgStyleAttribute, !string.IsNullOrEmpty(imageInfo.AltText) ? new XAttribute(NoNamespace.alt, imageInfo.AltText) : null); | |
| var altAttribute = !string.IsNullOrEmpty(imageInfo.AltText) | |
| ? new XAttribute(NoNamespace.alt, imageInfo.AltText) | |
| : null; | |
| return new XElement( | |
| Xhtml.img, | |
| new XAttribute(NoNamespace.src, cidReference), | |
| imageInfo.ImgStyleAttribute, | |
| altAttribute | |
| ); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.