feat: integrate reference product workload contract#1
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 872959dc3a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| name: 'APPLICATIONINSIGHTS_CONNECTION_STRING' | ||
| value: applicationInsightsConnectionString |
There was a problem hiding this comment.
In every environment, this connection string is the only Application Insights authentication-related setting injected, but observability.bicep retains DisableLocalAuth: true and the template creates neither APPLICATIONINSIGHTS_AUTHENTICATION_STRING=Authorization=AAD nor a Monitoring Metrics Publisher assignment for the workload identity. Consequently, connection-string/local-auth telemetry is rejected, while the system-assigned identity also lacks the configuration and permission required for Entra-authenticated ingestion, so the newly integrated workload cannot send Application Insights telemetry.
Useful? React with 👍 / 👎.
| param workflowBackend string = 'local' | ||
|
|
||
| @description('Foundry project endpoint. Required by the application when workflowBackend is foundry.') | ||
| param foundryProjectEndpoint string = '' | ||
|
|
||
| @description('Foundry Next Gen agent name. Required by the application when workflowBackend is foundry.') | ||
| param foundryAgentName string = '' |
There was a problem hiding this comment.
When an operator selects workflowBackend = 'foundry' but leaves either Foundry endpoint or agent name empty, the template still validates and deploys because both required application inputs default to empty strings without any cross-parameter assertion. The resulting Container App receives an invalid Foundry configuration and, according to the documented readiness contract, cannot become ready; reject this combination before deployment rather than allowing an unusable revision.
Useful? React with 👍 / 👎.
2 participants
Summary
Validation