Skip to content

feat(backups): support verified S3 object storage#49

Merged
Coding-Dev-Tools merged 1 commit into
mainfrom
codex/s3-commercial-backups
Jul 22, 2026
Merged

feat(backups): support verified S3 object storage#49
Coding-Dev-Tools merged 1 commit into
mainfrom
codex/s3-commercial-backups

Conversation

@Coding-Dev-Tools

Copy link
Copy Markdown
Owner

Summary

  • add encrypted commercial-backup delivery to private S3-compatible object storage, including Railway Buckets
  • verify the uploaded object by reading it back and comparing its complete SHA-256 digest before publishing readiness
  • keep only a credential-free v2 status marker on the live volume and preserve the existing filesystem backup path
  • enforce HTTPS, complete credentials, bounded prefixes, remote retention, and fail-closed readiness

Verification

  • ruff check engraphis/commercial.py tests/test_commercial_ga.py
  • python -m pytest tests/test_commercial_ga.py tests/test_commercial_backup.py -q

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7b0433055a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread engraphis/commercial.py
Comment on lines +351 to +352
response = client.list_objects_v2(
Bucket=config["bucket"], Prefix=config["prefix"] + "/" + PREFIX)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Paginate remote retention cleanup

When this prefix contains more than the first S3 listing page of backup objects (for example, after a long-running deployment or after a prior retention failure), list_objects_v2 returns only the first page and this code never follows IsTruncated/NextContinuationToken. Objects on subsequent pages are never considered for deletion, so the advertised remote retention policy silently stops bounding storage growth. Iterate all pages (and batch deletes as needed) before returning success.

Useful? React with 👍 / 👎.

@Coding-Dev-Tools
Coding-Dev-Tools merged commit 0a44036 into main Jul 22, 2026
8 checks passed
@Coding-Dev-Tools
Coding-Dev-Tools deleted the codex/s3-commercial-backups branch July 22, 2026 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant