Doding dojo JS edition - Sudoku solver Kata. Artur Wodarz solution#1
Doding dojo JS edition - Sudoku solver Kata. Artur Wodarz solution#1ArtWodarz wants to merge 2 commits intoCodingDojoSilesia:masterfrom
Conversation
inirudebwoy
left a comment
inirudebwoy
left a comment
There was a problem hiding this comment.
Thanks for sending your solution.
| function parseToArray(sudokuAsString) { | ||
| let sudokuArray = helper.createMatrix(9); | ||
| sudokuAsString.split("").forEach((el, index) => { | ||
| sudokuArray[Math.floor(index / 9)][index % 9] = el != "_" ? parseInt(el) : null; |
There was a problem hiding this comment.
This Math.floor(index / 9)[index %9]is clever 😃
but it also is not tested. Since this is the smartest part of the whole function I'd move this calculation into a separate function that returns a tuple.
function arrayPosition(index: number): [number, number];
|
|
||
| describe("Sudoku one", function() { | ||
| it("should be solved", function() { | ||
| var unsolved_sudoku = "___26_7_168__7__9_19___45__82_1___4___46_29___5___3_28__93___74_4__5__367_3_18___"; |
There was a problem hiding this comment.
This is a small inconsistency. Using linter and formatter may help you with these.
| if (sudokuMatrix[x][y] == null) sudokuMatrix[x][y] = 0; | ||
| let newUnique = helper.findUniqueInt( | ||
| sudokuMatrix[x][y], | ||
| 9, |
There was a problem hiding this comment.
This is a magic number. It also can be retrieved from parsed matrix dimension.
| const parser = require("./sudokuParser"); | ||
| const helper = require("./helper"); | ||
|
|
||
| function getRelatedCells(cell, sudokuMatrix) { |
There was a problem hiding this comment.
When reading body of solve function my initial though when reached line with getRelatedCells was to look into helper module. I was wrong 😄 Maybe you should move it there.
| while (helper.inRange(0, modifiableCells.length - 1, nowModified)) { | ||
| let x = modifiableCells[nowModified].row; | ||
| let y = modifiableCells[nowModified].col; | ||
| if (sudokuMatrix[x][y] == null) sudokuMatrix[x][y] = 0; |
There was a problem hiding this comment.
So you only set the cell to 0 so helper.findUniqueInt can work. You should move this if into helper function.
Separate functions should not be aware of such details.
| return block; | ||
| } | ||
|
|
||
| function extractRow(rowIndex, matrix) { |
There was a problem hiding this comment.
You missed unit tests for this function.
2 participants
No description provided.