-
Notifications
You must be signed in to change notification settings - Fork 0
Feat/version 6 0 3 #140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/version 6 0 3 #140
Changes from all commits
19d5930
2c7c16b
0be5dd5
c560b02
c47b30f
799b1b8
740a3f7
693e1ee
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -6,29 +6,29 @@ | |
| "use client"; | ||
|
|
||
| import { Badge } from "@/components/ui/badge"; | ||
| import { Card, CardContent } from "@/components/ui/card"; | ||
| import { Card } from "@/components/ui/card"; | ||
| //import { Card, CardContent } from "@/components/ui/card"; | ||
| import { Background } from "@/components/visuals/motion-background"; | ||
| import { GitHubShowcase } from "@/components/github"; | ||
| import type { AboutTranslations } from "@/types/configs/i18n"; | ||
| import Image from "next/image"; | ||
| import { motion } from "framer-motion"; | ||
| //import { motion } from "framer-motion"; | ||
|
||
| import { useTranslations } from "next-intl"; | ||
|
|
||
| // Animation variants | ||
| const fadeInUp = { | ||
| /* const fadeInUp = { | ||
| hidden: { opacity: 0, y: 20 }, | ||
| visible: { opacity: 1, y: 0 }, | ||
| }; | ||
| }; */ | ||
|
Comment on lines
+18
to
+21
|
||
|
|
||
| const staggerChildren = { | ||
| /* const staggerChildren = { | ||
| hidden: { opacity: 0 }, | ||
| visible: { | ||
| opacity: 1, | ||
| transition: { | ||
| staggerChildren: 0.1, | ||
| }, | ||
| }, | ||
| }; | ||
| }; */ | ||
|
|
||
| export default function AboutPage() { | ||
| const t = useTranslations("About"); | ||
|
|
@@ -42,7 +42,7 @@ export default function AboutPage() { | |
| <Background /> | ||
| <div className="relative z-10"> | ||
| {/* Hero Section */} | ||
| <section className="pt-32 pb-20 px-4 lg:px-8"> | ||
| <section className="pt-12 pb-20 px-4 lg:px-8"> | ||
| <div className="max-w-6xl mx-auto"> | ||
| <Card className="p-8 lg:p-12 bg-background/80 backdrop-blur-sm border-border/50 shadow-lg"> | ||
| <div className="grid lg:grid-cols-2 gap-12 items-center"> | ||
|
|
@@ -95,7 +95,7 @@ export default function AboutPage() { | |
| </section> | ||
|
|
||
| {/* Philosophy Section */} | ||
| <section className="py-20 px-4 lg:px-8"> | ||
| {/* <section className="py-20 px-4 lg:px-8"> | ||
| <div className="max-w-4xl mx-auto"> | ||
| <Card className="p-10 bg-background/80 backdrop-blur-sm border-border/50 shadow-lg"> | ||
| <motion.div | ||
|
|
@@ -119,7 +119,7 @@ export default function AboutPage() { | |
| </div> | ||
| </section> | ||
|
|
||
| {/* What I Deliver Section */} | ||
|
|
||
| <section className="py-20 px-4 lg:px-8"> | ||
| <div className="max-w-6xl mx-auto"> | ||
| <motion.div | ||
|
|
@@ -151,14 +151,7 @@ export default function AboutPage() { | |
| </div> | ||
| </motion.div> | ||
| </div> | ||
| </section> | ||
|
|
||
| {/* GitHub Showcase Section */} | ||
| <section className="py-20 px-4 lg:px-8" id="github"> | ||
| <div className="max-w-6xl mx-auto"> | ||
| <GitHubShowcase /> | ||
| </div> | ||
| </section> | ||
| </section> */} | ||
| </div> | ||
| </div> | ||
| ); | ||
|
|
||
This file was deleted.
This file was deleted.
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -1,17 +1,22 @@ | ||||||
| /** | ||||||
| * @author ColdByDefault | ||||||
| * @copyright 2026 ColdByDefault. All Rights Reserved. | ||||||
| */ | ||||||
|
|
||||||
| 'use client'; | ||||||
| import {ProjectsShowcase} from "@/components/projects"; | ||||||
| */ | ||||||
|
|
||||||
| "use client"; | ||||||
| import GitHubShowcase from "@/components/github/GitHubShowcase"; | ||||||
| import { ProjectsShowcase } from "@/components/projects"; | ||||||
|
|
||||||
| export default function LibraryPage() { | ||||||
|
||||||
| export default function LibraryPage() { | |
| export default function ProjectsPage() { |
Copilot
AI
Feb 17, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This introduces a duplicate id=\"github\" in the DOM because GitHubShowcase itself renders a <section id=\"github\">.... Duplicate IDs can break anchor navigation and accessibility. Remove the wrapper id, or update GitHubShowcase to accept an optional id prop so only one element owns the anchor.
This file was deleted.
This file was deleted.
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are several commented-out imports and large commented blocks left in the page. This makes the file harder to maintain and can hide accidental regressions. Prefer removing dead code entirely (or gating it behind a feature flag/config) rather than keeping commented code in the main branch.