feat: First checkin for the ical direct features#189
feat: First checkin for the ical direct features#189dploeger wants to merge 6 commits intoColdTrick:masterfrom
Conversation
|
@jdalsem can you find some time checking this out? Thanks. |
|
i enabled the automated checks on this PR. You might want to fix them first. After that i will do a detailed review of the code. At first glance it looks ok (with some minor remarks). I was wondering how you see this working together with the AddThisEvent feature (which also supports ical downloads). Should users choose on or the other? Maybe you could squash all your commits into one.. we do not need all the development commits in our history |
Sure. Will do, thanks.
I've made it selectable in the code. AddThisEvent doesn't support iCal imports and is a US-based company so many people will favor a local embedded version (at least we would 😅)
Yes, of course. I usually do a rebase with fixups once everything is settled. |
|
lol 4 comments... something went wrong probably If this can provide the same feature as AddThisEvent, we might choose to drop that. It is just an 'easy' solution (from the past). No specific needs... maybe the links in the mail footer is special |
|
Shouldn't use the GitHub app on an unstable 5G connection apparently. 😂 Sure, the iCal export also works fine on mobile with direct import into the calendar app. Although users who use the AddThisEvent app already might want to keep it. |
This implements a feature I called "ical direct" offering ical export and import features without the need of an external provider.
Features: