Skip to content

feat: First checkin for the ical direct features#189

Open
dploeger wants to merge 6 commits intoColdTrick:masterfrom
wabuehamm:feature/dpr/icaldirect
Open

feat: First checkin for the ical direct features#189
dploeger wants to merge 6 commits intoColdTrick:masterfrom
wabuehamm:feature/dpr/icaldirect

Conversation

@dploeger
Copy link

@dploeger dploeger commented Jan 9, 2026

This implements a feature I called "ical direct" offering ical export and import features without the need of an external provider.

Features:

  • Exporting an event (with currently only basic information) is the first implementation done (i18n wasn't yet done)
  • Exporting single events as well as a (optionall filtered) list of events
  • Importing single events and complete calendars from ical

@dploeger dploeger marked this pull request as ready for review January 27, 2026 14:11
@dploeger
Copy link
Author

dploeger commented Feb 4, 2026

@jdalsem can you find some time checking this out? Thanks.

@jdalsem
Copy link
Member

jdalsem commented Feb 9, 2026

i enabled the automated checks on this PR. You might want to fix them first. After that i will do a detailed review of the code.

At first glance it looks ok (with some minor remarks).

I was wondering how you see this working together with the AddThisEvent feature (which also supports ical downloads). Should users choose on or the other?

Maybe you could squash all your commits into one.. we do not need all the development commits in our history

@dploeger
Copy link
Author

dploeger commented Feb 9, 2026

i enabled the automated checks on this PR. You might want to fix them first. After that i will do a detailed review of the code.

Sure. Will do, thanks.

I was wondering how you see this working together with the AddThisEvent feature (which also supports ical downloads). Should users choose on or the other?

I've made it selectable in the code. AddThisEvent doesn't support iCal imports and is a US-based company so many people will favor a local embedded version (at least we would 😅)

Maybe you could squash all your commits into one.. we do not need all the development commits in our history

Yes, of course. I usually do a rebase with fixups once everything is settled.

@jdalsem
Copy link
Member

jdalsem commented Feb 9, 2026

lol 4 comments... something went wrong probably

If this can provide the same feature as AddThisEvent, we might choose to drop that. It is just an 'easy' solution (from the past). No specific needs... maybe the links in the mail footer is special

@dploeger
Copy link
Author

dploeger commented Feb 9, 2026

Shouldn't use the GitHub app on an unstable 5G connection apparently. 😂

Sure, the iCal export also works fine on mobile with direct import into the calendar app.

Although users who use the AddThisEvent app already might want to keep it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants