Skip to content

Return node when it contains the other node - with unit test #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kapouer wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Return node when it contains the other node - with unit test #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,10 @@ function getCommonAncestor(node) {
}

var nodes = slice.call(arguments, 1)
var list = parents(node)
list.unshift(node)

return parents(node).filter(function (parent) {
return list.filter(function (parent) {
return nodes.every(function (node) {
return contains(parent, node)
})
Expand Down
14 changes: 14 additions & 0 deletions test/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,20 @@ test("is correct", function (assert) {
assert.end()
})

test("is correct with inner child", function (assert) {
var one = elem()
var two = elem()
var three = elem()

one.appendChild(two)
two.appendChild(three)

var ancestor = commonAncestors(two, three)

assert.equal(ancestor, two)
assert.end()
})

test("doesn't return false positives", function (assert) {
var one = elem()
var two = elem()
Expand Down