Production Release#1658
Open
tarunnjoshi wants to merge 113 commits intomainfrom
Open
Conversation
Feature pan card validation
…iption-expire-reminder
Subscription expire reminder
Adds a temporary sleep(3) inside generateInvoiceNumber() between the SELECT FOR UPDATE and Contribution::update() calls. This holds the row lock and widens the race window, making it trivial to reproduce the CRM_Utils_Cache_SqlGroup duplicate-INSERT error (coloredcow-admin/goonj-crm#305) with the concurrent webhook script. Also adds the webhook simulation script and test results from 5 runs (100 requests, 4% failure rate without the sleep). DO NOT MERGE — this is a test-only branch for reproducing the bug. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Only the sleep(3) test code belongs in this PR. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
test: widen race condition for issue #305 reproduction
Move the sleep(3) from inside the FOR UPDATE locked section in generateInvoiceNumber() to the unlocked generateInvoiceIdForContribution(). This ensures multiple concurrent Contribution::update() calls actually overlap, reproducing Tarun's exact CRM_Utils_Cache_SqlGroup duplicate INSERT error rather than the deadlock at Contribution::create level. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Performance Fixes
Meeting workflow
Urban planned visit enhancement
…-to-surepass Update Pan card service to Surepass
cache fixes for import
Recurring reminder
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.