Skip to content

Conversation

@Molkobain
Copy link
Contributor

Base information

Question Answer
Related to a SourceForge thread / Another PR / Combodo ticket? #20
Type of change? Bug fix

Symptom (bug) / Objective (enhancement)

See #20

Reproduction procedure (bug)

See #20

Cause (bug)

See #20

Proposed solution (bug and enhancement)

Set the conf/msmtprc/msmtprc through a volume instead of a COPY instruction in the DockerFile.

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have tested all changes I made on an iTop instance
  • Would a unit test be relevant and have I added it?
  • Is the PR clear and detailed enough so anyone can understand without digging in the code?

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a critical build failure introduced in PR #19 where the PHP Dockerfile attempted to copy the msmtprc configuration file from outside the build context. The solution changes from build-time file copying to runtime volume mounting, which is consistent with how other configuration files are handled in this project.

Changes:

  • Removed COPY and RUN instructions from the PHP Dockerfile that attempted to access files outside the build context
  • Added a volume mount in docker-compose.yml to provide the msmtprc configuration file at runtime

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
docker-compose.yml Added read-only volume mount for msmtprc configuration file, consistent with php.ini and xdebug.ini patterns
build/php Removed invalid COPY instruction and related chmod/chown commands that caused build failures

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants