fix(api-nodes): Tencent TextToModel and ImageToModel nodes#12680
fix(api-nodes): Tencent TextToModel and ImageToModel nodes#12680
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughAdds 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@comfy_api_nodes/nodes_hunyuan3d.py`:
- Line 59: The iterable in the extension check using a set literal in the
condition (elif any(lower.endswith(ext) for ext in {".png", ".jpg", ".jpeg",
".bmp", ".tiff", ".webp"})) is causing a lint error; change the set literal to a
sequence type (e.g., a tuple or list) so the generator iterates over a stable
sequence — update that line to use (" .png", ".jpg", ".jpeg", ".bmp", ".tiff",
".webp") or similar (referencing the same variable 'lower' and the
any(...endswith(ext)...) check) to fix pylint C0208.
0eb33b5 to
c86ff0a
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@comfy_api_nodes/nodes_hunyuan3d.py`:
- Around line 54-60: The ZIP extraction loop using zipfile.ZipFile can crash or
exhaust memory: before calling zf.read(name) for either the .obj (obj_bytes) or
textures (BytesIO(...)), check the entry size via zf.getinfo(name).file_size and
enforce an explicit max size (reject or skip entries exceeding the limit); when
decoding textures call bytesio_to_image_tensor inside a try/except and on
failure log/skip the texture and leave texture_tensor as None (so the optional
texture output can fail gracefully) — adjust code around zipfile.ZipFile, the
loop over zf.namelist(), and the variables obj_bytes, texture_tensor, BytesIO,
and bytesio_to_image_tensor accordingly.
4dccc18 to
b520528
Compare
…d TencentImageToModel nodes. Fixed `OBJ` output when it is zipped
b520528 to
1ea727b
Compare
OBJoutput when it is zippedAPI Node PR Checklist
Scope
Pricing & Billing
If Need pricing update:
QA
Comms