Conversation
3891921 to
46e81bd
Compare
46e81bd to
710a65f
Compare
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughAdds a new Reve API integration module 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@comfy_api_nodes/nodes_reve.py`:
- Around line 162-179: The Reve proxy requests are sending sensitive data
(prompts, base64 uploads, image bytes) through sync_op_raw which logs
request/response payloads; modify the calls using sync_op_raw (e.g., the calls
that pass ApiEndpoint and ReveImageCreateRequest in the image create flow and
the similar blocks around the other mentions) to use a redaction/no-payload
logging path: either pass a flag/option to sync_op_raw to disable body/response
logging for these endpoints or create a wrapper that strips or replaces
sensitive fields (prompt, uploaded image data, any base64 fields, and binary
responses) before the logging step; update the calls that build the request
payload (ReveImageCreateRequest and _build_postprocessing) to provide a
sanitized version to the logger while still sending the full payload to the
network layer.
In `@comfy_api_nodes/util/client.py`:
- Around line 776-781: The code converts resp.headers to a plain dict
(resp_headers = dict(resp.headers)) which loses case-insensitive lookup; instead
pass the original resp.headers (the CIMultiDictProxy) to the callbacks so
cfg.price_extractor and cfg.response_header_validator can do case-insensitive
.get lookups. Replace the dict(...) conversion and pass resp.headers (or wrap
with multidict.CIMultiDict if you must) to the calls to cfg.price_extractor and
cfg.response_header_validator so header lookups like
headers.get("x-reve-credits-used") work regardless of header casing.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 88fbe532-856c-4a60-bee0-5d7fc190668d
⛔ Files ignored due to path filters (1)
comfy_api_nodes/apis/reve.pyis excluded by!comfy_api_nodes/apis/**
📒 Files selected for processing (2)
comfy_api_nodes/nodes_reve.pycomfy_api_nodes/util/client.py
API Node PR Checklist
Scope
Pricing & Billing
If Need pricing update:
QA
Comms