ci(bump-callers): trigger the pr-size fleet on the Go counter source, not just pr-size.yml (BE-3482)#48
Conversation
Self-review pass: bump-pr-size-callers.yml only watched pr-size.yml, missing scripts/check-pr-size/** where the actual counting logic lives (consumers pin that Go tool via workflows_ref, same as cursor-review's assets pattern) -- a behavior change there wouldn't have triggered a caller bump. Also cleaned up stale "two entrypoints" comments in the two sibling files now that a third fleet exists.
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 38 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Comment |
Fast-follow to #35 (merged): a self-review pass caught this after #35 landed, so
it's a small standalone PR rather than reopening the merged one.
What
bump-pr-size-callers.ymlonly triggered on changes topr-size.ymlitself.But the actual counting logic consumers run lives in
scripts/check-pr-size/**—
pr-size.yml's own header says the size job builds that Go tool from theworkflows_refSHA a caller pins, mirroring howcursor-review.ymlchecks out.github/cursor-review/*at the same pinned ref. So a behavior-changing editto the Go counter wouldn't trigger a caller SHA-bump, and pinned callers would
silently keep running stale tool behavior.
Fix: add
scripts/check-pr-size/**to the fleet's trigger paths (mirroring howbump-agents-md-callers.ymlalready watches both its workflow file and.github/agents-md-integrity/**), and update the README fleet table row tomatch. Also cleaned up two stale "two entrypoints" comments in the sibling
fleet files left over from before #35 added the third fleet.
Test plan
shellcheck -x .github/bump-callers/bump-callers.sh .github/bump-callers/tests/test_bump_callers.shbash .github/bump-callers/tests/test_bump_callers.sh(86/86 pass)