ci(bump-cursor-review): trigger on .github/cursor-review/** asset changes (BE-3916)#50
Conversation
…nges (BE-3916) The bump-cursor-review-callers fleet only triggered on changes to .github/workflows/cursor-review.yml, but that workflow's runtime behavior is not self-contained: consumers check out this repo's .github/cursor-review/* prompts + scripts (e.g. extract-findings.py) at the pinned workflows_ref SHA. A behavior-changing edit under .github/cursor-review/** therefore changes what every pinned caller runs without opening a SHA-bump PR, so consumers silently stayed on the old revision. Add .github/cursor-review/** to the push path filter, mirroring the agents-md (.github/agents-md-integrity/**) and pr-size (scripts/check-pr-size/**) fleets, and update the bump-callers README fleet table row for consistency.
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 19 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Comment |
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @mattmillerai.
✅ No high-signal findings.
Panel: 8/8 reviewers contributed findings.
ELI-5
When someone edits the cursor-review workflow file, a robot automatically opens "please update your pinned version" PRs in every repo that uses it. But cursor-review's real behavior also lives in sibling scripts and prompts (
.github/cursor-review/**, e.g.extract-findings.py) that consumers pull in at the exact SHA they pinned. Editing one of those scripts changes what every pinned caller runs — but the robot didn't wake up for it, so consumers silently kept running the old (possibly buggy) script. This PR makes the robot also wake up on.github/cursor-review/**changes, so a fix to a prompt/script fans out a bump PR just like a workflow-file change does.What changed
.github/workflows/bump-cursor-review-callers.yml— added.github/cursor-review/**to thepush:path filter (previously only.github/workflows/cursor-review.yml), with an inline comment explaining why. This mirrors the two sibling fleets that already do this:.github/workflows/agents-md-integrity.yml+.github/agents-md-integrity/**.github/workflows/pr-size.yml+scripts/check-pr-size/**.github/bump-callers/README.md— updated the fleet table's "Triggers on a change to" cell tocursor-review.ymlorcursor-review/**, matching the agents-md row's phrasing.Why
cursor-review.ymlis not self-contained: its checkout steps pull this repo's.github/cursor-review/*prompts + scripts atinputs.workflows_ref(the SHA a consumer pins). So a behavior-changing edit under.github/cursor-review/**changes what every pinned caller runs, yet did not trigger a SHA-bump PR — consumers silently stayed on the old revision. Deferred from a review thread on #35 as out of scope there.Testing
bash .github/bump-callers/tests/test_bump_callers.sh→ 88 passed, 0 failedshellcheck -x .github/bump-callers/bump-callers.sh .github/bump-callers/tests/test_bump_callers.sh→ cleanpython3 -c "import yaml; yaml.safe_load(...)"on the edited workflow → validNo test changes needed — this is purely a trigger-path addition, not a change to
bump-callers.sh.Notes / judgment calls
.github/cursor-review/**also matchestests/**andREADME.md, so a test-only or docs-only edit would open a bump PR. This exactly matches the siblingagents-md-integrity/**andcheck-pr-size/**patterns, and the bumper is idempotent (an already-pinned SHA is a clean skip), so the slight over-breadth is the accepted, consistent tradeoff.test-bump-callers.ymldid not need.github/cursor-review/**added — it runs the bump-callers unit suite and already triggers on the editedbump-cursor-review-callers.yml. The README's "add paths totest-bump-callers.yml" note is for registering a new entrypoint, not for widening an existing fleet's runtime trigger.Closes BE-3916.