Skip to content

Migrate Numeric core_exts to correct directory #1238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wwahammy merged 3 commits into from
Jun 27, 2025
Merged

Migrate Numeric core_exts to correct directory #1238

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9bd46a4
Migrate Numeric core_exts to correct directory
wwahammy Jun 27, 2025
fcdcc80
Remove migrated numeric
wwahammy Jun 27, 2025
64e2f57
Merge branch 'supporter_level_goal' into migrate-numeric
wwahammy Jun 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions app/legacy_lib/calculate_suggested_amounts.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
# License: AGPL-3.0-or-later WITH Web-Template-Output-Additional-Permission-3.0-or-later

module CalculateSuggestedAmounts
require_relative "numeric" # this is loading the local numeric

MIN = 25
MAX = 100000000
BRACKETS = [{range: MIN...1000, delta: 100},
Expand Down
0 app/legacy_lib/numeric.rb → lib/core_ext/numeric.rb
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion spec/lib/numeric_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# License: AGPL-3.0-or-later WITH Web-Template-Output-Additional-Permission-3.0-or-later
require "numeric"
require "core_ext/numeric"

describe Numeric do
describe "#floor_for_delta" do
Expand Down