Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
0024b23
Turn on `config.add_autoload_paths_to_load_path = false`
wwahammy May 21, 2025
30436f1
Fix zeitwerk error for Mailchimp
wwahammy Jun 26, 2025
7862a49
Improve `to_deprecated_h` initializer
wwahammy Jun 26, 2025
7f3a8f0
Remove autoloaded `format/name` require
wwahammy Jun 26, 2025
06c8faf
Merge branch 'remove-unused-nonprofits_controller#create' into to-rai…
wwahammy Jun 27, 2025
289e2d6
Remove unneeded requires from HealthReport
wwahammy Jun 27, 2025
2614b69
Remove unused requires in InsertActivities
wwahammy Jun 27, 2025
95908c3
Remove unused requires
wwahammy Jun 27, 2025
efdabaf
Remove unused requires
wwahammy Jun 27, 2025
4cd6b8c
Delete more requires
wwahammy Jun 27, 2025
5cc725c
Merge branch 'remove-empty-class' into to-rails-7.1-defaults
wwahammy Jun 27, 2025
b024423
Remove unused requires
wwahammy Jun 27, 2025
0160697
Remove more requires
wwahammy Jun 27, 2025
afc316a
Remove the unneed autoloads
wwahammy Jun 27, 2025
5f9c2ac
Merge branch 'to-rails-7.1-defaults' into to-more-rails-7.1-defaults
wwahammy Jun 28, 2025
56e7e92
Merge branch 'to-rails-7.1-defaults' into to-more-rails-7.1-defaults
wwahammy Jun 28, 2025
0981c2d
Remove unused `require "cypher"` from `InsertNonprofitKeys`
wwahammy Jun 28, 2025
e00500a
Remove unused `Hash.with_defaults_unless_nil` method
wwahammy Jun 28, 2025
57c84a7
Merge branch 'remove-unused-hash' into to-more-rails-7.1-defaults
wwahammy Jun 28, 2025
11946a6
Merge branch 'remove-unused-require' into to-more-rails-7.1-defaults
wwahammy Jun 28, 2025
e531656
Undo the encryption change
wwahammy Jun 28, 2025
968183c
Set `active_support.raise_on_invalid_cache_expiration_time = true` be…
wwahammy Jun 28, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions app/legacy_lib/delayed_job_helper.rb
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
# License: AGPL-3.0-or-later WITH Web-Template-Output-Additional-Permission-3.0-or-later
require "qx"
require "delayed_job"

module DelayedJobHelper
# Create a serialized delayed job handler for use in inserting new delayed jobs with raw sql
Expand Down
1 change: 0 additions & 1 deletion app/legacy_lib/format/csv.rb
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
# License: AGPL-3.0-or-later WITH Web-Template-Output-Additional-Permission-3.0-or-later
require "csv"
require "format/currency"

module Format
module Csv
Expand Down
7 changes: 0 additions & 7 deletions app/legacy_lib/hash.rb

This file was deleted.

3 changes: 0 additions & 3 deletions app/legacy_lib/health_report.rb
Original file line number Diff line number Diff line change
@@ -1,7 +1,4 @@
# License: AGPL-3.0-or-later WITH Web-Template-Output-Additional-Permission-3.0-or-later
require "qx"
require "format/csv"
require "format/currency"

module HealthReport
# Send an email report about what has happend on the servers and database in the last 24hrs, and how things are running
Expand Down
4 changes: 0 additions & 4 deletions app/legacy_lib/insert_activities.rb
Original file line number Diff line number Diff line change
@@ -1,8 +1,4 @@
# License: AGPL-3.0-or-later WITH Web-Template-Output-Additional-Permission-3.0-or-later
require "qx"
require "active_support/core_ext"
require "format/currency"
require "format/date"

module InsertActivities
def self.insert_cols
Expand Down
8 changes: 0 additions & 8 deletions app/legacy_lib/insert_charge.rb
Original file line number Diff line number Diff line change
@@ -1,12 +1,4 @@
# License: AGPL-3.0-or-later WITH Web-Template-Output-Additional-Permission-3.0-or-later
# require 'psql'
# require 'qexpr'
# require 'calculate/calculate_fees'
# require 'stripe'
# require 'get_data'
# require 'active_support/core_ext'

require "stripe_account" unless !Settings.payment_provider.stripe_connect

module InsertCharge
# In data, pass in: amount, nonprofit_id, supporter_id, card_id, statement
Expand Down
1 change: 0 additions & 1 deletion app/legacy_lib/insert_email_lists.rb
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
# License: AGPL-3.0-or-later WITH Web-Template-Output-Additional-Permission-3.0-or-later
require "qx"

module InsertEmailLists
def self.for_mailchimp(npo_id, tag_master_ids)
Expand Down
8 changes: 0 additions & 8 deletions app/legacy_lib/insert_import.rb
Original file line number Diff line number Diff line change
@@ -1,12 +1,4 @@
# License: AGPL-3.0-or-later WITH Web-Template-Output-Additional-Permission-3.0-or-later
# require 'qx'
# require 'required_keys'
# require 'open-uri'
# require 'csv'
# require 'insert/insert_supporter'
# require 'insert/insert_full_contact_infos'
# require 'insert/insert_custom_field_joins'
# require 'insert/insert_tag_joins'

module InsertImport
# Wrap the import in a transaction and email any errors
Expand Down
2 changes: 0 additions & 2 deletions app/legacy_lib/insert_nonprofit_keys.rb
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
# License: AGPL-3.0-or-later WITH Web-Template-Output-Additional-Permission-3.0-or-later
require "httparty"
require "cypher"

module InsertNonprofitKeys
include HTTParty
Expand Down
8 changes: 0 additions & 8 deletions app/legacy_lib/insert_payout.rb
Original file line number Diff line number Diff line change
@@ -1,14 +1,6 @@
# License: AGPL-3.0-or-later WITH Web-Template-Output-Additional-Permission-3.0-or-later
# Create a new payout

# require 'psql'
# require 'qexpr'
# require 'query/query_payments'
# require 'update/update_charges'
# require 'update/update_refunds'
# require 'update/update_disputes'
# require 'param_validation'

module InsertPayout
# Pass in the following inside the data hash:
# - stripe_account_id
Expand Down
2 changes: 0 additions & 2 deletions app/legacy_lib/insert_tag_joins.rb
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
# License: AGPL-3.0-or-later WITH Web-Template-Output-Additional-Permission-3.0-or-later
require "psql"
require "qx"

module InsertTagJoins
# @param [Integer] np_id id for a [Nonprofit]
Expand Down
7 changes: 0 additions & 7 deletions app/legacy_lib/periodic_report_adapter.rb
Original file line number Diff line number Diff line change
@@ -1,12 +1,5 @@
# License: AGPL-3.0-or-later WITH Web-Template-Output-Additional-Permission-3.0-or-later
class PeriodicReportAdapter
extend ActiveSupport::Autoload

autoload :CancelledRecurringDonationsReport
autoload :FailedRecurringDonationsReport
autoload :ActiveRecurringDonationsToCsvReport
autoload :StartedRecurringDonationsToCsvReport

REPORT = "Report"
private_constant :REPORT

Expand Down
2 changes: 0 additions & 2 deletions app/legacy_lib/query_campaign_gifts.rb
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
# License: AGPL-3.0-or-later WITH Web-Template-Output-Additional-Permission-3.0-or-later
# Query code for both campaign_gift_options and campaign_gifts

require "psql"

module QueryCampaignGifts
# Create a mapping of: {
# 'total_donations' => Integer, # total donations for gift options
Expand Down
1 change: 0 additions & 1 deletion app/legacy_lib/query_campaigns.rb
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
# License: AGPL-3.0-or-later WITH Web-Template-Output-Additional-Permission-3.0-or-later
require "qexpr"

module QueryCampaigns
def self.timeline(campaign_id)
Expand Down
5 changes: 0 additions & 5 deletions app/legacy_lib/query_supporters.rb
Original file line number Diff line number Diff line change
@@ -1,9 +1,4 @@
# License: AGPL-3.0-or-later WITH Web-Template-Output-Additional-Permission-3.0-or-later
require "qexpr"
require "psql"
require "email"
require "format/currency"
require "format/csv"

module QuerySupporters
# Query supporters and their donations and gift levels for a campaign
Expand Down
2 changes: 2 additions & 0 deletions config/application.rb
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@ class Application < Rails::Application
# Initialize configuration defaults for originally generated Rails version.
config.load_defaults 7.0

config.add_autoload_paths_to_load_path = false # only until line above is set to 7.1

# Please, add to the `ignore` list any other `lib` subdirectories that do
# not contain `.rb` files, or that should not be reloaded or eager loaded.
# Common ones are `templates`, `generators`, or `middleware`, for example.
Expand Down
12 changes: 6 additions & 6 deletions config/initializers/mailchimp.rb
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# License: AGPL-3.0-or-later WITH Web-Template-Output-Additional-Permission-3.0-or-later
require "mailchimp"

Mailchimp.config({
api_key: ENV["MAILCHIMP_API_KEY"],
username: ENV["MAILCHIMP_USERNAME"]
})
Rails.application.config.after_initialize do
Mailchimp.config({
api_key: ENV["MAILCHIMP_API_KEY"],
username: ENV["MAILCHIMP_USERNAME"]
})
end
4 changes: 2 additions & 2 deletions config/initializers/new_framework_defaults_7_1.rb
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@
# 3. If you don't currently have data encrypted with Active Record encryption, you can disable this setting to
# configure the default behavior starting 7.1+:
#++
Rails.application.config.active_record.encryption.support_sha1_for_non_deterministic_encryption = false
# Rails.application.config.active_record.encryption.support_sha1_for_non_deterministic_encryption = false

###
# No longer run after_commit callbacks on the first of multiple Active Record
Expand Down Expand Up @@ -101,7 +101,7 @@
# Options are `true`, and `false`. If `false`, the exception will be reported
# as `handled` and logged instead.
#++
# Rails.application.config.active_support.raise_on_invalid_cache_expiration_time = true
Rails.application.config.active_support.raise_on_invalid_cache_expiration_time = true

###
# Specify whether Query Logs will format tags using the SQLCommenter format
Expand Down
6 changes: 4 additions & 2 deletions config/initializers/to_deprecated_h.rb
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
ActiveSupport.on_load(:action_controller_base) do
require "to_deprecated_h"
# License: AGPL-3.0-or-later WITH Web-Template-Output-Additional-Permission-3.0-or-later
Rails.application.config.after_initialize do
# this is hacky way to autoload app/legacy_lib/to_deprecated_h.rb on startup
ToDeprecatedH
end
11 changes: 0 additions & 11 deletions spec/lib/hash_spec.rb

This file was deleted.

Loading