Skip to content

T3096 Refactor letters display#2093

Merged
ecino merged 1 commit into
14.0from
ecino/refactor-letter-selection
Apr 14, 2026
Merged

T3096 Refactor letters display#2093
ecino merged 1 commit into
14.0from
ecino/refactor-letter-selection

Conversation

@ecino
Copy link
Copy Markdown
Member

@ecino ecino commented Apr 14, 2026

  • ADD new field for tracking date of Exit communication sent to sponsor
  • FIX is_final_letter field

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new exit_communication_sent field to track when exit communications are sent to partners, including a post-migration script to backfill existing data. It also refactors the final letter logic and updates the correspondence tree view decoration. Feedback focuses on the migration script, highlighting a logic error in the SQL query's operator precedence, potential false positives when matching IDs in strings, and several performance issues related to database operations inside loops. Additionally, it is recommended to use UTC time for consistency with Odoo's standards.

Comment thread partner_communication_compassion/migrations/14.0.1.2.0/post-migration.py Outdated
- ADD new field for tracking date of Exit communication sent to sponsor
- FIX is_final_letter field
@ecino ecino force-pushed the ecino/refactor-letter-selection branch from e332177 to f653dbb Compare April 14, 2026 12:35
@ecino ecino merged commit 63bd6b3 into 14.0 Apr 14, 2026
1 check passed
@ecino ecino deleted the ecino/refactor-letter-selection branch April 14, 2026 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant