T3093 new sponsorship flow#315
Merged
Merged
Conversation
- FIX: A sign up and login text + button are shown if the user is not signed in - FIX: translations started, DE and IT are still missing
- FIX: made sure the text works in all languages regardless of the position of the name in the translation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a call to action for guest users on the sponsorship thank-you page, encouraging them to sign up or log in to manage their new sponsorship. It includes updated translation files for German, French, and Italian. A high-severity issue was identified in the template where the thank-you message was assigned to a variable, which prevents it from being translated at runtime; the reviewer recommends using the translation function directly within the template to ensure proper localization.
ecino
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(translations provided by Olivier, Monica and Serena)