Skip to content

T3093 new sponsorship flow#315

Merged
ecino merged 3 commits into
14.0from
T3093-new-sponsorship-flow
Apr 16, 2026
Merged

T3093 new sponsorship flow#315
ecino merged 3 commits into
14.0from
T3093-new-sponsorship-flow

Conversation

@Danielgergely
Copy link
Copy Markdown
Member

  • FIX: A sign up and login text + button are shown if the user is not signed in
  • FIX: made sure the text works in all languages regardless of the position of the name in the translation

(translations provided by Olivier, Monica and Serena)

- FIX: A sign up and login text + button are shown if the user is not signed in
- FIX: translations started, DE and IT are still missing
- FIX: made sure the text works in all languages regardless of the position of the name in the translation
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a call to action for guest users on the sponsorship thank-you page, encouraging them to sign up or log in to manage their new sponsorship. It includes updated translation files for German, French, and Italian. A high-severity issue was identified in the template where the thank-you message was assigned to a variable, which prevents it from being translated at runtime; the reviewer recommends using the translation function directly within the template to ensure proper localization.

Comment thread my_compassion/templates/pages/my2_new_sponsorship_wizard.xml
@ecino ecino merged commit d5f2183 into 14.0 Apr 16, 2026
1 check passed
@ecino ecino deleted the T3093-new-sponsorship-flow branch April 16, 2026 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants