T3090 utm qr code#321
Merged
Merged
Conversation
Member
Danielgergely
commented
Apr 16, 2026
Danielgergely
commented
- FEAT: extract UTM variables from url
- FIX: this enables unauthenticated users to access a child's page (when for example scanning a qr code on a child pack)
- FIX: this enables unauthenticated users to access a child's page (when for example scanning a qr code on a child pack)
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces UTM parameter tracking for sponsorship wizards by capturing parameters from the URL, storing them in the session, and linking them to the resulting sponsorship record. Key feedback includes a security concern regarding the automatic creation of UTM records from public input, which could lead to database pollution. Other recommendations involve refactoring repetitive logic into a loop, using integer route converters for better validation, and adopting more idiomatic Odoo methods like browse() for record retrieval.
- REFACTOR: using for loop for more efficiency - FIX: campaign is now not auto created. needs to exist before assignment, otherwise it will be ignored. - FIX: using int instead of string for child id, and browse instead of a normal search
ecino
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.