[T2577] FIX: mobile menu now appears from the left#323
Conversation
- REFACTOR: Improved mobile menu by increasing size and placing cart and language selector in the same row - REFACTOR: increased the size of the language selector for better UX - FIX: mobile menu now appears from the left - FEAT: added an 'x' to close the menu
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request implements an off-canvas mobile menu and integrates the cart and language selector into the new layout. Key feedback includes ensuring the language selector is accessible to unauthenticated mobile users, fixing a visibility gap for the cart link on tablet-sized screens, and addressing an accessibility issue where hidden menu items remain focusable. Additionally, the font size for the mobile menu's close button should be reduced for better visual balance.
- FIX: added language selector to hamburger menu on mobile screens - REFACTOR: simplified language selector scss - FEAT: added visibility selectors for better accessibility support - FIX: hiding hamburger menu on md screens and added margin to language selector
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request implements an off-canvas mobile menu and integrates the cart and language selector into the header for both mobile and desktop views. The review feedback focuses on resolving inconsistencies between the responsive breakpoints used in the XML templates and the SCSS media queries, specifically recommending the use of md instead of lg for synchronization. Additionally, suggestions were made to refine the visibility logic of the mobile toggler and to reduce the reliance on !important in the language selector styles to improve CSS maintainability.
1 participant
Uh oh!
There was an error while loading. Please reload this page.