T3122 letter timeline changes#326
Open
Danielgergely wants to merge 2 commits into
Open
Conversation
Member
Danielgergely
commented
Apr 28, 2026
Danielgergely
commented
- FIX: long wait time disclaimer is displayed when the last letter is S2B
- FIX: corrected/added translations
- FIX: long wait time disclaimer is displayed when the last letter is S2B
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds a disclaimer to the child timeline regarding mail delivery times and updates translations for German, French, and Italian. The review feedback points out that the template logic for showing the disclaimer is unreliable as it only checks the initial batch of records and does not account for infinite scrolling. Furthermore, the updated translations for "Wrote you a letter" in German and French are noted as misleading for letters sent by the supporter, as they incorrectly suggest the user is the recipient rather than the sender.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.