Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Improves various logic to speed up loading conditional, especially dashboard
On CSH ethernet
Before: 6.3 seconds
After: 1.4 seconds
On VPN to my home in state college
Before: 6.5 seconds
After: 1.5 seconds
(After I thought about this, not sure if the vpn test is doing what I want because I would've thought that I couldn't reach the db since I wouldn't have been on cshnet but idk)
Why
Conditional was painfully slow to load before, especially when loading a fresh instance
Test Plan
Compared all the various stats on dashboard with both spring and fall semester data
What I checked:
/housing)Env Vars
nope
Checklist