cleaned up a fucntion because it gave me a stroke everytime#3
Open
aln730 wants to merge 2 commits intoComputerScienceHouse:masterfrom
Open
cleaned up a fucntion because it gave me a stroke everytime#3aln730 wants to merge 2 commits intoComputerScienceHouse:masterfrom
aln730 wants to merge 2 commits intoComputerScienceHouse:masterfrom
Conversation
Mstrodl
requested changes
Mar 22, 2026
Mstrodl
reviewed
Mar 27, 2026
Comment on lines
+23
to
+24
| (Weekday::Mon | Weekday::Tue | Weekday::Wed | Weekday::Thu, 0..7) | ||
| | (Weekday::Mon | Weekday::Tue | Weekday::Wed | Weekday::Thu, 23..) => true, |
Member
There was a problem hiding this comment.
Suggested change
| (Weekday::Mon | Weekday::Tue | Weekday::Wed | Weekday::Thu, 0..7) | |
| | (Weekday::Mon | Weekday::Tue | Weekday::Wed | Weekday::Thu, 23..) => true, | |
| (Weekday::Mon | Weekday::Tue | Weekday::Wed | Weekday::Thu, 0..7 | 23..) => true, |
Contributor
Author
There was a problem hiding this comment.
Meh, I was unsure if patterns for ranges work like that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
cleaned up get_volume function.
Why
it gave me a stroke every time I read it.
Test Plan
tested locally
Env Vars
none
Documentation
none. not required
Checklist