Skip to content

Fix: bundle Action runtime with ncc to vendor agent-gov-core #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Conalh merged 1 commit into from
May 22, 2026
Merged

Fix: bundle Action runtime with ncc to vendor agent-gov-core #18

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,4 +50,4 @@ outputs:

runs:
using: node24
main: dist/action.js
main: dist/action-bundle/index.js
1 change: 1 addition & 0 deletions dist/action-bundle/index.js
View file
Open in desktop

Large diffs are not rendered by default.

3 changes: 3 additions & 0 deletions dist/action-bundle/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
{
"type": "module"
}
11 changes: 11 additions & 0 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 3 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,14 +7,16 @@
"capabilityecho": "./dist/index.js"
},
"scripts": {
"build": "tsc -p tsconfig.json",
"build": "tsc -p tsconfig.json && npm run bundle-action",
"bundle-action": "ncc build src/action.ts -o dist/action-bundle --minify",
"test": "node --test test/*.test.mjs"
},
"dependencies": {
"agent-gov-core": "github:Conalh/agent-gov-core#v0.1.2"
},
"devDependencies": {
"@types/node": "^24.0.0",
"@vercel/ncc": "^0.38.4",

Check warning on line 19 in package.json

View workflow job for this annotation

GitHub Actions / scope-review

TaskBound medium scope creep 

Added dependency @vercel/ncc@^0.38.4. Recommendation: Confirm the dependency is required for the stated task.
"typescript": "^5.9.3"
},
"license": "MIT"
Expand Down
2 changes: 1 addition & 1 deletion test/workflow.test.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ test('action.yml exposes capability drift outputs', async () => {
test('action.yml runs the checked-in JavaScript action without installing PR-local scripts first', async () => {
const action = await readFile(join(packageRoot, 'action.yml'), 'utf8');

assert.match(action, /runs:\s*\r?\n\s+using: node24\r?\n\s+main: dist\/action\.js/);
assert.match(action, /runs:\s*\r?\n\s+using: node24\r?\n\s+main: dist\/action-bundle\/index\.js/);
assert.doesNotMatch(action, /using: composite/);
assert.doesNotMatch(action, /npm ci/);
assert.doesNotMatch(action, /npm run build/);
Expand Down