[codex] Harden GitHub Action runtime#3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/action.tsto run the existing diff/report engine directly, write step summaries, emit GitHub warning annotations, set outputs, and enforcefail-on.dist/runtime and update the dogfood workflow to callConalh/CapabilityEcho@maininstead of PR-local./action code.Root cause
The live demo PR showed that
uses: ./plus the old composite action executednpm ciin the PR-local action checkout before CapabilityEcho scanned the diff. That meant a PR adding a maliciouspostinstallcould run before being reported.Validation
npm run buildnpm test(14/14 pass)node dist/index.js diff --old test/fixtures/capability-drift/old --new test/fixtures/capability-drift/new --format markdowngit diff --check(exit 0; CRLF normalization warnings only)Notes
This PR is intentionally scoped to making the free GitHub Action credible as a scanner that does not execute PR-local install/build scripts before review.