[codey] Track bundled Action dist#32
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
v0.1.15dist/and commits the built CLI files thataction.ymlruns from published tagsdistfiles are trackedv0.1.16Root cause
PR #29 made the composite Action execute
$GITHUB_ACTION_PATH/dist/index.js, but.gitignorestill ignoreddist/and nodistfiles were tracked. That meant the publishedv0.1.15tag did not actually contain the bundled CLI expected by the Action runtime.Verification
node --test test/workflow.test.mjs(red before trackingdist, green after)npm run buildnpm test(37/37)node dist/index.js audit --repo . --format json(ratingnone, 0 findings)node dist/index.js audit --repo test/fixtures/conflicted --format githubgit diff --checkgit diff --cached --check