Namespace finding kinds with 'scope_trail.' prefix (agent-gov-core@v0.2.0)#40
Merged
Conversation
Adopts agent-gov-core v0.2.0 and prefixes every Finding.kind with the 'scope_trail.' namespace per the suite-wide v1.0 wire-format wave (agent-gov-core#1). Kinds renamed (16): codex_approval_weakened -> scope_trail.codex_approval_weakened codex_network_enabled -> scope_trail.codex_network_enabled codex_project_trusted -> scope_trail.codex_project_trusted codex_sandbox_widened -> scope_trail.codex_sandbox_widened hook_added -> scope_trail.hook_added hook_command_changed -> scope_trail.hook_command_changed hook_removed -> scope_trail.hook_removed mcp_sample_remote_endpoint -> scope_trail.mcp_sample_remote_endpoint mcp_sample_server_added -> scope_trail.mcp_sample_server_added mcp_sample_server_command_changed -> scope_trail.mcp_sample_server_command_changed mcp_sample_unpinned_command -> scope_trail.mcp_sample_unpinned_command mcp_server_added -> scope_trail.mcp_server_added mcp_server_command_changed -> scope_trail.mcp_server_command_changed permission_allow_widened -> scope_trail.permission_allow_widened permission_deny_removed -> scope_trail.permission_deny_removed unpinned_mcp_command -> scope_trail.unpinned_mcp_command Pure rename — no detector semantics changed, no severities changed. Test assertions updated to the new prefixed form. Bumps agent-gov-core dep to #v0.2.0 (which enforces the dotted form via the JSON schema's kind regex).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the suite-wide v1.0 wire-format wave tracked in agent-gov-core#1. Prefixes every Finding.kind with the tool's ToolKind so a downstream meta-reviewer can dedupe across tools (e.g. ScopeTrail's permission_allow_widened never collides with another tool's).
Changes
agent-gov-coredep#v0.1.2→#v0.2.0(which addskind()+isNamespacedKind()and enforces the dotted form via the JSON schema regex)scope_trail.Not changed
Verification
npm install && npm run build— cleannpm test— 36/36 passing on the new prefixed assertions