Skip to content

chore: update GitHub Actions workflows for permissions and versioning#23

Open
eloi010 wants to merge 3 commits into
mainfrom
update-gh-actions
Open

chore: update GitHub Actions workflows for permissions and versioning#23
eloi010 wants to merge 3 commits into
mainfrom
update-gh-actions

Conversation

@eloi010

@eloi010 eloi010 commented Jun 23, 2026

Copy link
Copy Markdown
Collaborator

chore: update GitHub Actions workflows for permissions and versioning


Note

Low Risk
CI workflow-only changes with least-privilege permissions and dependency pin updates; no application runtime impact.

Overview
Hardens GitHub Actions by setting workflow-level permissions: {} on nft-resolver-tests and security-code-scanner, so jobs only get the scopes they declare explicitly.

For nft-resolver tests, the job now grants contents: read and actions: write, bumps actions/checkout to v6.0.3, and sets persist-credentials: false on checkout.

For security scanning, the reusable MetaMask scanner workflow is bumped from v2.0.6 to v2.1.0; the job’s actions/contents/security-events permissions are unchanged.

Reviewed by Cursor Bugbot for commit 63900b3. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-advanced-security

Copy link
Copy Markdown

You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool.

What Enabling Code Scanning Means:

  • The 'Security' tab will display more code scanning analysis results (e.g., for the default branch).
  • Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results.
  • You will be able to see the analysis results for the pull request's branch on this overview once the scans have completed and the checks have passed.

For more information about GitHub Code Scanning, check out the documentation.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR tightens GitHub Actions security by explicitly setting minimal default GITHUB_TOKEN permissions at the workflow level and updates pinned action/workflow SHAs for reproducibility.

Changes:

  • Add workflow-level permissions: {} to reduce default token scopes.
  • Bump actions/checkout pin from v6.0.2 to v6.0.3 in the test workflow.
  • Bump MetaMask security scanner reusable workflow pin from v2.0.6 to v2.1.0.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
.github/workflows/security-code-scanner.yml Adds workflow-level minimal permissions and updates the pinned reusable security scan workflow SHA.
.github/workflows/nft-resolver-tests.yml Adds workflow-level minimal permissions and updates the pinned checkout action SHA for the CI test workflow.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +8 to 12
permissions: {}

jobs:
nft-resolver-tests:
runs-on: ubuntu-latest
Comment thread .github/workflows/nft-resolver-tests.yml

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit beb06e3. Configure here.

Comment thread .github/workflows/nft-resolver-tests.yml

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

Comment thread .github/workflows/nft-resolver-tests.yml

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants