fix: pubkeyToHexColor returns fallback color instead of throwing on empty string#19
Open
Priyanshubhartistm wants to merge 2 commits into
Open
Conversation
When validateAndDecodePubkey returns null for an invalid pubkey, the calculateTrustScore function now sets a validationError state instead of silently returning. The error message is displayed below the Calculate button in red. Fixes ContextVM#16
… empty string
pubkeyToHexColor was throwing an Error when called with an empty string,
which caused template expressions to crash before the pubkey prop had
loaded (e.g. style="background-color: {pubkeyToHexColor(pubkey)}").
Replace the throw with a return of '#888888' (neutral grey) so the
function is safe to call directly inside Svelte template expressions
during loading states.
Fixes ContextVM#18
|
@Priyanshubhartistm is attempting to deploy a commit to the ContextVM's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #18
pubkeyToHexColorwas throwingError('Pubkey is required')when called with an empty string. Because this function is invoked directly inside Svelte template expressions (e.g.style="background-color:{pubkeyToHexColor(pubkey)}"), the error was propagating before thepubkeyprop had finished loading, crashing the component render.Root Cause