Allow user to pass a pre-configured SSL_CTX to the client.#456
Open
pgit wants to merge 2 commits intoCopernicaMarketingSoftware:masterfrom
Open
Allow user to pass a pre-configured SSL_CTX to the client.#456pgit wants to merge 2 commits intoCopernicaMarketingSoftware:masterfrom
pgit wants to merge 2 commits intoCopernicaMarketingSoftware:masterfrom
Conversation
pgit
changed the title
Member
|
Have you also tried to add extra methods to the TcpHandler class for initialization/construction of the ssl context? I find the extra parameter a bit odd. |
Contributor
Author
|
Added a new overload of onSecuring() that userspace can use to return a SSL_CTX. Not quite sure about naming here. Also, are there no concerns about ABI breakage from adding a new method to the vtable? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using a secure connection, the
onSecuring()callback is invoked with a pointer to a freshly created OpenSSLSSLobject. You can then install certificates etc. on this session object.This session object is created from a 'template'
SSL_CTXobject, which stores the defaults for all newly created SSL sessions. Some applications might have a pre-configuredSSL_CTXand use that for configuring the SSL connection.This patch adds a way to pass a pre-configured
SSL_CTXto the connection, which is used instead of the one that is constructed internally.