Move Copilot.Compile.Bluespec.External out of shared directory. Refs #36.#38
Merged
RyanGlScott merged 3 commits intomasterfrom Mar 20, 2025
Merged
Move Copilot.Compile.Bluespec.External out of shared directory. Refs #36.#38RyanGlScott merged 3 commits intomasterfrom
Copilot.Compile.Bluespec.External out of shared directory. Refs #36.#38RyanGlScott merged 3 commits intomasterfrom
Conversation
The non-public `Copilot.Compiler.Bluespec.External` module lives under a `shared/` directory so that it be imported by both the library code and the test suite code. This is a questionable design, as it means that the code for the library is not self-contained in a single `src/` directory. (There exists a similar problem for the test suite.) The comments in `Copilot.Compiler.Bluespec.External` mistakenly reference the C99 backend instead of the Bluespec backend, which will make it confusing for users when this module is moved to a more prominent, Bluespec-specific location. This commit fixes the comments to reference the Bluespec backend instead.
. The non-public `Copilot.Compiler.Bluespec.External` module lives under a `shared/` directory so that it be imported by both the library code and the test suite code. This is a questionable design, as it means that the code for the library is not self-contained in a single `src/` directory. (There exists a similar problem for the test suite.) This commit moves `Copilot.Compiler.Bluespec.External` from `shared/` to `src/`. It also creates a duplicate version of the module under the name `Test.Copilot.Compiler.Bluespec.External`. This code duplication is not ideal, but it is better than the previous status quo. The task of de-duplicating it will be deferred to a separate issue (#3).
ivanperez-keera
approved these changes
Mar 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The non-public
Copilot.Compiler.Bluespec.Externalmodule lives under ashared/directory so that it be imported by both the library code and the test suite code. This is a questionable design, as it means that the code for the library is not self-contained in a singlesrc/directory. (There exists a similar problem for the test suite.)This commit moves
Copilot.Compiler.Bluespec.Externalfromshared/tosrc/. It also creates a duplicate version of the module under the nameTest.Copilot.Compiler.Bluespec.External. This code duplication is not ideal, but it is better than the previous status quo. The task of de-duplicating it will be deferred to a separate issue (#3).Fixes #36.