Open
Conversation
g7ed6e
force-pushed
the
feature/add-mixed-auth-allowanonymous
branch
3 times, most recently
from
75415b1 to
2745dd3
Compare
g7ed6e
force-pushed
the
feature/add-mixed-auth-allowanonymous
branch
from
2745dd3 to
6465d21
Compare
kevinchalet
reviewed
Jan 18, 2023
kevinchalet
left a comment
kevinchalet
left a comment
There was a problem hiding this comment.
Since you sent me the link via LinkedIn, I took the liberty to add a few remarks 😃
(I focused on the OpenIddict stuff and ignored the CoreWCF part as I'm not familiar at all with the stack)
Scenarios/Authentication/Mixed-auth-allow-anonymous-workaround/Idp/Program.cs
Outdated
Show resolved
Hide resolved
Scenarios/Authentication/Mixed-auth-allow-anonymous-workaround/Idp/Program.cs
Show resolved
Hide resolved
Scenarios/Authentication/Mixed-auth-allow-anonymous-workaround/Idp/Program.cs
Outdated
Show resolved
Hide resolved
|
|
||
| var builder = WebApplication.CreateBuilder(); | ||
|
|
||
| builder.Services.AddAuthentication(JwtBearerDefaults.AuthenticationScheme) |
There was a problem hiding this comment.
It might be a good idea to add a note indicating that OpenIddict also has a validation handler that uses a more recent JWT stack, can easily switch to OAuth 2.0 introspection and is compatible with any standard OAuth 2.0 implementation (i.e not just OpenIddict.Server).
Scenarios/Authentication/Mixed-auth-allow-anonymous-workaround/Service/Program.cs
Outdated
Show resolved
Hide resolved
g7ed6e
force-pushed
the
feature/add-mixed-auth-allowanonymous
branch
from
6465d21 to
a797f03
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.