[Feature] Popover when setting Link#1
Open
CorreyL wants to merge 14 commits into
Open
Conversation
Coding timeblock exceeded, stopping for now to resume another day
Fixes bug where the Popover would not close when adding a link to previously selected text
Replace the original text, in-case the user inputted new text
Setting `to` to displayText.length only works if `from === 1` (i.e. the cursor is at the beginning of the textbox) The correct calculation is to offset from `from`, then add `displayText.length` to it
Saves the user presses on the keyboard from having to type the protocol, while leaving it editable on the off-chance the user wishes to change it to http://, or some other protocol
Original bug fixed, new bug found
If the cursor was in the middle of text with a hyperlink, or only part of the text with a hyperlink was selected, then the displayText would not accurately reflect the full text that the link was associated with Since this refactor required accessing and modifying the editor, pass the editor as a prop instead, and instantiate what were previously props as variables within the InsertLinkForm component
Fixed in 8bec5f9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As a small personal coding challenge, I expanded upon the idea suggested here:
amruthpillai#1727 (comment)
This PR replaces the
window.promptfor adding/editing a link in the Text Editor with aPopovercomponentVideo.mp4
The details in this PR will be expanded upon if the Reactive Resume maintainers have any interest in this feature being added to the main codebase.