feat: include memory ID in store/update response text#146
Open
eisen0419 wants to merge 1 commit intoCortexReach:masterfrom
Open
feat: include memory ID in store/update response text#146eisen0419 wants to merge 1 commit intoCortexReach:masterfrom
eisen0419 wants to merge 1 commit intoCortexReach:masterfrom
Conversation
Include the full memory ID in the response text of `memory_store` and `memory_update` tools so the AI model can verify successful persistence and reference specific entries. - `memory_store`: add `(ID: <uuid>)` to response text - `memory_update`: show full ID instead of truncated 8-char prefix Closes CortexReach#139
Collaborator
|
Codex static review summary: Overall this looks low-risk and directionally correct. I did not find any security, resource, or logic bugs in the actual ID interpolation itself. One compatibility note: this changes the user-visible Suggestion before merge: add minimal regression coverage to lock the new success text for both My conclusion: approve with nits. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
memory_storeandmemory_updatetoolsChanges
memory_store: Added(ID: <uuid>)to response textStored: "..." in scope 'agent:main'Stored: "..." (ID: 8f82f232-...) in scope 'agent:main'memory_update: Show full ID instead of truncated 8-char prefixUpdated memory 8f82f232...: "..."Updated memory (ID: 8f82f232-abc1-4def-...): "..."Test plan
memory_storeresponse includes full UUID in text fieldmemory_updateresponse includes full UUID in text fielddetails.idfield remains unchangedCloses #139