fix: wire 4 orphaned test files into npm test (65 cases)#162
Open
fix: wire 4 orphaned test files into npm test (65 cases)#162
Conversation
access-tracker.test.mjs (59), self-improvement.test.mjs (3), session-recovery-paths.test.mjs (2), jsonl-distill-slash-filter.test.mjs (1) were present in test/ but never executed by `npm test`. All 4 pass independently on master. Note: the pre-existing smart-extractor-branches.mjs failure (LLM-dependent assertion) is unrelated to this change. memory-reflection.test.mjs is intentionally excluded — it has a known failing assertion on the sessionStrategy default value. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Codex review correctly identified that the 4 newly wired tests were placed after the known-flaky smart-extractor-branches.mjs, meaning they never actually ran in `npm test`. Move the flaky test to the end of the chain so all deterministic tests execute first. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test/access-tracker.test.mjs(59 cases),test/self-improvement.test.mjs(3),test/session-recovery-paths.test.mjs(2),test/jsonl-distill-slash-filter.test.mjs(1) were present intest/but never executed bynpm test.package.json. All 4 files usenode:testand are invoked withnode --test.Verification
master(65/65, exit code 0).memory-reflection.test.mjsis intentionally not included — it has a known failing assertion (sessionStrategydefault value).smart-extractor-branches.mjsfailure (LLM-dependent assertion at line 470) is unrelated to this change.Change
Only
package.jsonline 38 (scripts.test) is modified. No source code changes.🤖 Generated with Claude Code