Update: pin Trust to v1.1.1 and correct canonical ownership#498
Open
0xLeif wants to merge 2 commits into
Open
Conversation
β¦pec/commands.rs
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Contributor
There was a problem hiding this comment.
β Corvin says...
_
<(;\ .oO(oh no...)
|/(\
\(\\
" "\\
"I'm pecking through the errors..."
CI Summary
| Check | Status |
|---|---|
| Dependency Audit | β Passed |
| Integration (3 OS) | β cancelled |
| Lint (fmt + clippy) | β Passed |
| Spec Validation | β failure |
| Tests (3 OS) | β Passed |
Powered by corvid-pet
Contributor
There was a problem hiding this comment.
β Corvin says...
_
<(^\ .oO(Caw! ^v^)
|/(\
\(\\
" "\\
"Looking sharp! Like a beak should be."
CI Summary
| Check | Status |
|---|---|
| Dependency Audit | β Passed |
| Integration (3 OS) | β Passed |
| Lint (fmt + clippy) | β Passed |
| Spec Validation | β Passed |
| Tests (3 OS) | β Passed |
Powered by corvid-pet
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.github/workflows/trust.ymlfrom9d32b5786d2e9e4d39fc581c0091c721ee3d4226 # v1.0.0toa239f78658e5ad0f12fa230f494890e40c6e4d7b # v1.1.1(immutable commit SHA).CHG-0001-adopt-trust-1-and-specsync-5(SpecSync 5.1.1change correct-owner):src/spec/commands.rsβ owned by spec modulespec(perspecs/spec/spec.spec.mdfrontmatterfiles:)src/templates.rsβ owned by spec moduletemplates(perspecs/templates/templates.spec.mdfrontmatterfiles:)CHG-0001with the note: "Re-acceptance with canonical ownership correction for src/spec/commands.rs; canonical deltas were already integrated and were not replayed."Background
specsync change accept CHG-0001-adopt-trust-1-and-specsync-5was blocked by:(and subsequently the same for
src/templates.rs). CHG-0001 is a no-spec change (affected_specsempty), so the sanctioned SpecSync 5.1.1 per-path fixspecsync change correct-ownerwas applied against the canonical spec modules whose frontmatterfiles:lists already include these paths. No spec files were edited; the only non-.specsync/change is the Trust pin in.github/workflows/trust.yml.Verification
specsync change verify CHG-0001-adopt-trust-1-and-specsync-5β passed (verify-native lane: 962 unit tests + all integration suites green, build, template validation; 10 templates, 0 errors).specsync checkβ clean (exit 0):