fix: parse local registries with real TOML (closes #413)#461
Open
0xLeif wants to merge 3 commits into
Open
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
There was a problem hiding this comment.
❌ Corvin says...
_
<(;\ .oO(oh no...)
|/(\
\(\\
" "\\
"I'm pecking through the errors..."
CI Summary
| Check | Status |
|---|---|
| Validate action.yml | ✅ Passed |
| Packaged Action Consumer | ✅ Passed |
| Dependency Audit | ✅ Passed |
| Code Coverage | ✅ Passed |
| Format Check | ❌ failure |
| Docs Site | ✅ Passed |
| Spec Validation | ❌ failure |
| Tests (build, test, clippy) | ✅ Passed |
| VS Code Extension | ✅ Passed |
📋 Spec Validation Details
❌ SpecSync: Failed
| Metric | Value |
|---|---|
| Specs checked | 62 |
| Passed | 62 |
| Errors | 1 |
| Warnings | 0 |
| File coverage | 100% (105/105) |
| LOC coverage | 100% (86967/86967) |
Errors
- meaningful changed paths are not covered by an active change: Cargo.lock, Cargo.toml, src/registry.rs
Action Items
- Review and fix -- meaningful changed paths are not covered by an active change: Cargo.lock, Cargo.toml, src/registry.rs
Generated by specsync · Run specsync check --format github to reproduce
Powered by corvid-pet
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Local registry handling (
src/registry.rs) used a line scanner instead of a real TOML parser:name=line (e.g.name = {{{) was silently accepted, violating the fail-closed contract.Fix
tomlcrate dependency).failed to parse local registry …error;is_inert_legacy_registry_stubno longer treats garbage as inert.Regression tests
parse_registry_supports_documented_modules_shapeload_local_registry_fails_closed_on_malformed_toml_with_name_linemodules_entry_missing_spec_key_is_an_errorcanonical_resolution_tolerates_inert_legacy_registry_stuband bothsemantic_application_*registry*tests now pass.drills/012-registry-parser-realities.shValidation
cargo test +
cargo clippy -- -D warningsgreen (only pre-existing root-only failurechange::tests::non_git_walk_skips_volatile_trees_but_fails_on_relevant_walk_errors).Closes #413