Support universal builds#34
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the Xcode version management system to support universal builds by restructuring the API models and filtering releases based on architecture compatibility.
Key changes:
- Restructured API response models to include architecture information
- Added architecture detection and filtering for download compatibility
- Added a
prefer-universalflag to prioritize universal builds
Reviewed Changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| Sources/XcodeVersionManager/Models/XcodeReleasesAPI.swift | New API client with enhanced response models including architecture support |
| Sources/XcodeVersionManager/Models/XcodeReleases.swift | Removed old API implementation |
| Sources/XcodeVersionManager/Models/XcodeRelease.swift | New domain model with architecture and OS version requirements |
| Sources/XcodeVersionManager/Models/CalendarDate.swift | New date model for release dates |
| Sources/XcodeVersionManager/Models/Architecture.swift | New architecture detection and enumeration |
| Sources/XcodeVersionManager/Commands/ListCommand.swift | Updated to use new API and added known releases subcommand |
| Sources/XcodeVersionManager/Commands/DownloadCommand.swift | Added architecture filtering and universal build preference |
| Sources/XcodeVersionManager/Commands/Arguments/InstalledXcodeVersion.swift | Updated completion handler signature |
| Package.swift | Updated dependency to use semantic versioning |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
040e140 to
eaca45c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.