[pull] master from curl:master#1616
Merged
Merged
Conversation
On Linux, and Windows cross-builds. clang-tidy jobs look significantly faster. Other jobs remain around the same (this feels nice after seeing the significant slowdowns in Windows-2025, FreeBSD 15.) Before: https://github.com/curl/curl/actions/runs/27770630688 After: https://github.com/curl/curl/actions/runs/27770913426?pr=22086 gcc-analyzer also got faster: Before: https://github.com/curl/curl/actions/runs/27758865007/job/82127670883 After: https://github.com/curl/curl/actions/runs/27768696084/job/82162385765 Also: - work around actionlint 1.7.12 not yet being aware of ubuntu-26.04: ``` windows.yml:770:14: label "ubuntu-26.04" is unknown. available labels are [...] ``` Ref: https://github.com/curl/curl/actions/runs/27769065782/job/82163700294#step:6:13 Ref: rhysd/actionlint#682 Ref: rhysd/actionlint#683 Follow-up to 5a2af80 #22084 Closes #22086
To use `tee` instead, due to `apt-key` being deprecated, and missing from recent distros. Also lowercase `stdin` to match rest of the file. Ref: https://documentation.ubuntu.com/release-notes/26.04/summary-for-lts-users/#package-management-apt-3 Follow-up to b13e906 #16127 Follow-up to 54130a6 #10170 Closes #22090
Fixing (as seen with gcc-15 on Ubuntu 26.04):
```
lib/smb.c: In function 'smb_connect':
lib/smb.c:491:9: error: assignment discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
491 | slash = strchr(user, '/');
| ^
lib/smb.c:493:11: error: assignment discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
493 | slash = strchr(user, '\\');
| ^
```
Ref: https://github.com/curl/curl/actions/runs/27778098314/job/82195462418?pr=22092
Follow-up to 4e59083 #20428
Follow-up to 7dc60bd #20425
Follow-up to 0e2507a #20421
Cherry-picked from #22092
Closes #22094
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )