Character allocation patch

[Erizur]

This is a patch that was quickly done as a proof-of-concept to increase the character (and flavor) table in the latest jam&fizz. unsure if it works on older games but it should be good to go. It will increase both tables to the maximum number found in both tables, and also added a few tweaks to the memory buffer logic.

Please note that most of the code was AI-assisted, but I manually overlooked it myself, and understand what it does. If there needs to be things that need to be tweaked I can cover it myself. Though, the general patch is relatively small.

[CrazyRedMachine]

hi,
thanks for the PR.

if it's a PoC what does it lack to be production-ready ?

Also, was the character table size causing issues ? I'm not sure from your message if this patch actually fixes something..

thanks again,

[Erizur]

Hi, thanks for the reply !! ^_^

if it's a PoC what does it lack to be production-ready ?

Oh, a little misunderstanding there, the original patch was a proof of concept, but I overlooked at it in order to create the PR.

Also, was the character table size causing issues ? I'm not sure from your message if this patch actually fixes something..

The character table was only allocated up to some point, around 20 slots after the last entry. Characters that used larger character IDs (like the pop'n music Lively ports) would crash, do nothing or corrupt an portion of the table. This wasn't really needed for basic modding since you could just fit characters onto the free slots, but adding more characters or using insanely large character ids would require reallocating more space for both the character + flavor tables, which is what this patch does. It increases according to the max character id and flavor id it finds on the data_mods list. Guess this wasn't really looked over since nobody was modding characters either way, but I was looking for this to port over the CS characters.

I can attach proof later if you want. Thanks again!