Some small enhancements to cli.hosting handling command and options validation results#66
Merged
Merged
Conversation
…and `OptionsValidationResult` - Introduce `Success` property and implicit conversion operator in `CommandResult`. - Add static `Valid` and `Invalid` methods in `OptionsValidationResult` for easier initialization. - Create comprehensive unit tests to validate the new changes.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds convenience methods to the CLI core classes to simplify creating validation and command results. The changes introduce static factory methods for OptionsValidationResult, a static success property and implicit operator for CommandResult, along with comprehensive test coverage for these enhancements.
- Added factory methods
Valid()andInvalid()toOptionsValidationResultfor cleaner result creation - Added
Successstatic property and implicit int operator toCommandResultfor more ergonomic usage - Introduced unit tests to validate the new functionality
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| source/Cli/CreativeCoders.Cli.Core/OptionsValidationResult.cs | Adds static factory methods Valid() and Invalid() to simplify creation of validation results |
| source/Cli/CreativeCoders.Cli.Core/CommandResult.cs | Adds static Success property and implicit operator from int for more concise command result creation |
| tests/CreativeCoders.Cli.Tests/Core/OptionsValidationResultTests.cs | Provides test coverage for the new Valid() and Invalid() factory methods, including null handling |
| tests/CreativeCoders.Cli.Tests/Core/CommandResultTests.cs | Validates the implicit operator with various exit code values including edge cases |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…nd usability - Add comprehensive XML documentation for `CommandResult`, `OptionsValidationResult`, `ICliHost`, `ICliCommandContext`, and `ICliHostBuilder`. - Update affected files to align with enhanced documentation standards.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.