Add pipeline and fan-out-merge composite route strategies by Copilot · Pull Request #192 · CrisisTextLine/modular

Copilot · 2026-03-06T21:31:11Z

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

…ests Co-authored-by: intel352 <77607+intel352@users.noreply.github.com>

Co-authored-by: intel352 <77607+intel352@users.noreply.github.com>

…ategies Co-authored-by: intel352 <77607+intel352@users.noreply.github.com>

github-actions · 2026-03-07T06:53:57Z

📋 API Contract Changes Summary

✅ No breaking changes detected - only additions and non-breaking modifications

Changed Components:

Core Framework

Contract diff saved to artifacts/diffs/core.json

Module: auth

Contract diff saved to artifacts/diffs/auth.json

Module: cache

Contract diff saved to artifacts/diffs/cache.json

Module: chimux

Contract diff saved to artifacts/diffs/chimux.json

Module: database

Contract diff saved to artifacts/diffs/database.json

Module: eventbus

Contract diff saved to artifacts/diffs/eventbus.json

Module: eventlogger

Contract diff saved to artifacts/diffs/eventlogger.json

Module: httpclient

Contract diff saved to artifacts/diffs/httpclient.json

Module: httpserver

Contract diff saved to artifacts/diffs/httpserver.json

Module: jsonschema

Contract diff saved to artifacts/diffs/jsonschema.json

Module: letsencrypt

Contract diff saved to artifacts/diffs/letsencrypt.json

Module: logmasker

Contract diff saved to artifacts/diffs/logmasker.json

Module: reverseproxy

Contract diff saved to artifacts/diffs/reverseproxy.json

Module: scheduler

Contract diff saved to artifacts/diffs/scheduler.json

Artifacts

📁 Full contract diffs and JSON artifacts are available in the workflow artifacts.

codecov · 2026-03-07T06:54:18Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 58.68%. Comparing base (185d00d) to head (5a14971).

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #192      +/-   ##
==========================================
- Coverage   61.54%   58.68%   -2.87%     
==========================================
  Files          82       82              
  Lines       17706    17726      +20     
==========================================
- Hits        10897    10402     -495     
- Misses       5769     6253     +484     
- Partials     1040     1071      +31

Flag	Coverage Δ
auth	`?`
bdd-auth	`70.97% <ø> (ø)`
bdd-cache	`67.15% <ø> (ø)`
bdd-chimux	`73.80% <ø> (ø)`
bdd-database	`51.85% <ø> (ø)`
bdd-eventbus	`69.91% <ø> (ø)`
bdd-eventlogger	`61.59% <ø> (ø)`
bdd-httpclient	`41.81% <ø> (ø)`
bdd-httpserver	`62.59% <ø> (ø)`
bdd-jsonschema	`77.31% <ø> (ø)`
bdd-letsencrypt	`19.70% <ø> (ø)`
bdd-logmasker	`36.02% <ø> (ø)`
bdd-reverseproxy	`54.71% <ø> (+0.02%)`	⬆️
bdd-scheduler	`60.97% <ø> (ø)`
cache	`?`
chimux	`?`
cli	`47.27% <ø> (ø)`
core-bdd	`17.70% <ø> (ø)`
database	`?`
eventbus	`?`
eventlogger	`?`
httpclient	`?`
httpserver	`?`
jsonschema	`?`
letsencrypt	`?`
logmasker	`?`
merged-bdd	`46.03% <ø> (+0.03%)`	⬆️
reverseproxy	`66.63% <ø> (-0.03%)`	⬇️
scheduler	`?`
total	`57.11% <ø> (ø)`
unit	`64.16% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot

Pull request overview

Adds two new composite route strategies to the modules/reverseproxy module to support dependent multi-backend workflows (sequential request chaining) and ID-correlated parallel response merging, plus configurable “empty backend response” handling.

Changes:

Introduces pipeline and fan-out-merge composite strategies with new config/types and execution logic.
Adds per-route empty-response policy support via config (empty_policy) and programmatic setters.
Adds unit tests + BDD scenarios, and updates the reverse-proxy example and README to document/illustrate usage.

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
modules/reverseproxy/module.go	Stores per-route pipeline configs, fan-out mergers, and empty-response policies; adds setter APIs.
modules/reverseproxy/composite.go	Wires new strategies into `CompositeHandler` + dispatch; plumbs config/module wiring into handler creation.
modules/reverseproxy/composite_pipeline.go	Implements pipeline + fan-out-merge execution logic and supporting types/helpers.
modules/reverseproxy/config.go	Adds `CompositeRoute.EmptyPolicy` config field (`empty_policy`).
modules/reverseproxy/composite_pipeline_test.go	New unit tests covering pipeline/fan-out-merge and empty-policy behavior.
modules/reverseproxy/features/composite_pipeline.feature	New BDD feature scenarios for pipeline/fan-out-merge and empty-policy behavior.
modules/reverseproxy/bdd_step_registry_test.go	Registers new godog steps for the added feature scenarios.
modules/reverseproxy/bdd_composite_pipeline_test.go	Implements BDD step definitions for the new feature scenarios.
modules/reverseproxy/README.md	Documents all composite strategies (including the two new ones) and empty-policy usage.
examples/reverse-proxy/main.go	Adds runnable example usage for pipeline and fan-out-merge strategies and mock backends.
examples/reverse-proxy/config.yaml	Adds example backends and composite route config entries for the new strategies.

Copilot · 2026-03-07T06:58:29Z

modules/reverseproxy/composite.go


+	// Set empty response policy from config if specified
+	if routeConfig.EmptyPolicy != "" {
+		handler.SetEmptyResponsePolicy(EmptyResponsePolicy(routeConfig.EmptyPolicy))


empty_policy is applied by casting the raw config string to EmptyResponsePolicy without validation. If a user misspells the value, the handler will silently fall back to the default behavior, making misconfigurations hard to detect. Consider validating routeConfig.EmptyPolicy against the allowed set (allow-empty/skip-empty/fail-on-empty) and returning a config error (or at least logging a warning and defaulting explicitly).

Suggested change

handler.SetEmptyResponsePolicy(EmptyResponsePolicy(routeConfig.EmptyPolicy))

switch routeConfig.EmptyPolicy {

case "allow-empty", "skip-empty", "fail-on-empty":

handler.SetEmptyResponsePolicy(EmptyResponsePolicy(routeConfig.EmptyPolicy))

default:

return nil, fmt.Errorf("invalid empty response policy %q for route %q: must be one of allow-empty, skip-empty, fail-on-empty", routeConfig.EmptyPolicy, routeConfig.Pattern)

}

Copilot · 2026-03-07T06:58:30Z

modules/reverseproxy/composite_pipeline.go

+	wg.Wait()
+
+	// Apply empty response policy
+	filteredResponses := make(map[string][]byte)
+	for backendID, body := range responses {
+		if isEmptyBody(body) {
+			switch h.emptyResponsePolicy {
+			case EmptyResponseFail:
+				w.WriteHeader(http.StatusBadGateway)
+				fmt.Fprintf(w, "Backend %s returned empty response", backendID)
+				return
+			case EmptyResponseSkip:


executeFanOutMerge will call the user-provided FanOutMerger even when no backend responses were collected (e.g., all requests failed or were skipped due to open circuit breakers). This differs from the existing merge/pipeline behavior which returns 502 when there are no successful responses, and it can lead to confusing 204/500 responses depending on the merger implementation. Consider short-circuiting with http.StatusBadGateway when len(responses)==0 (or after empty-policy filtering when len(filteredResponses)==0).

Copilot · 2026-03-07T06:58:30Z

modules/reverseproxy/composite_pipeline.go

+	return &http.Response{
+		Status:     http.StatusText(statusCode),
+		StatusCode: statusCode,
+		Header:     http.Header{"Content-Type": []string{"application/json"}},
+		Body:       io.NopCloser(bytes.NewReader(body)),
+	}, nil


MakeJSONResponse sets http.Response.Status to http.StatusText(statusCode) (e.g., "OK"), but per net/http conventions it should be the full status line (e.g., "200 OK") or left empty so it can be derived from StatusCode. Returning a response with an invalid Status can break callers that write the response via (*http.Response).Write. Consider setting Status to fmt.Sprintf("%d %s", statusCode, http.StatusText(statusCode)) or leaving it empty.

intel352 · 2026-03-09T15:48:39Z

@copilot apply changes based on the comments in this thread

Also fix the linter errors.

… fix MakeJSONResponse status format Co-authored-by: intel352 <77607+intel352@users.noreply.github.com>

Copilot · 2026-03-09T16:01:58Z

@copilot apply changes based on the comments in this thread

Also fix the linter errors.

Applied all three review changes in b20df85:

empty_policy validation — Added ErrInvalidEmptyResponsePolicy sentinel to errors.go; createCompositeHandler now returns fmt.Errorf("route %q empty_policy %q: %w", ..., ErrInvalidEmptyResponsePolicy) for any unrecognized value instead of silently defaulting.
Fan-out 502 on no responses — executeFanOutMerge now short-circuits with 502 both when all backends fail (len(responses) == 0) and when all responses are filtered out by the skip-empty policy (len(filteredResponses) == 0).
MakeJSONResponse status format — Status is now set to fmt.Sprintf("%d %s", statusCode, http.StatusText(statusCode)) (e.g. "200 OK").

Linter was also clean after adding the //nolint:gosec // G704 comment to the new http.NewRequestWithContext in composite.go. The two remaining lint issues (dryrun.go:206 and health_checker.go:174) are pre-existing.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

tenant-secondary
- Triggering command: /tmp/go-build1428529496/b001/reverseproxy.test /tmp/go-build1428529496/b001/reverseproxy.test -test.paniconexit0 -test.count=1 -test.timeout=1m0s -test.run=^Test[^R] n_comparison_tes-c=4 _system_scenario-nolocalimports s_test.go re_flag_dryrun_t/opt/hostedtoolcache/go/1.25.7/x64/pkg/tool/linux_amd64/vet re_flag_scenario-unsafeptr=false re_flag_steps_te-unreachable=false re_flags_test.go/tmp/go-build87120003/b247/vet.cfg h_ch�� h_circuit_test.go h_events_test.go (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

Reset GoCodeAlone/modular to CrisisTextLine/modular main (v1.11.11+16 commits). Changed all module paths from CrisisTextLine to GoCodeAlone. Merged CrisisTextLine#192 (composite route strategies). Added reimplementation plans for previously GoCodeAlone-specific features: - TenantGuard framework - Dynamic Reload Manager - Aggregate Health Service - BDD/Contract Testing framework Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Initial plan

786af3d

Copilot AI assigned Copilot and intel352 Mar 6, 2026

Copilot started work on behalf of intel352 March 6, 2026 21:31 View session

Copilot AI and others added 3 commits March 6, 2026 21:41

Add pipeline and fan-out-merge composite route strategies with unit t…

9134d6e

…ests Co-authored-by: intel352 <77607+intel352@users.noreply.github.com>

Add BDD tests for pipeline and fan-out-merge composite strategies

8dd31c8

Co-authored-by: intel352 <77607+intel352@users.noreply.github.com>

Update example, config, and README for pipeline and fan-out-merge str…

ec268bd

…ategies Co-authored-by: intel352 <77607+intel352@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Add support for mapping responses from multiple backends~~ Add pipeline and fan-out-merge composite route strategies Mar 6, 2026

Copilot finished work on behalf of intel352 March 6, 2026 22:12

intel352 marked this pull request as ready for review March 7, 2026 06:53

Copilot AI review requested due to automatic review settings March 7, 2026 06:53

Copilot started reviewing on behalf of intel352 March 7, 2026 06:53 View session

Copilot AI reviewed Mar 7, 2026

View reviewed changes

Copilot started work on behalf of intel352 March 9, 2026 15:48 View session

Address review feedback: validate empty_policy, 502 on empty fan-out,…

b20df85

… fix MakeJSONResponse status format Co-authored-by: intel352 <77607+intel352@users.noreply.github.com>

Copilot finished work on behalf of intel352 March 9, 2026 16:02

Merge branch 'main' into copilot/add-composite-route-support

5a14971

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add pipeline and fan-out-merge composite route strategies#192

Add pipeline and fan-out-merge composite route strategies#192
Copilot wants to merge 6 commits intomainfrom
copilot/add-composite-route-support

Copilot AI commented Mar 6, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Mar 7, 2026 •

edited

Loading

Uh oh!

codecov bot commented Mar 7, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Mar 7, 2026

Uh oh!

Copilot AI Mar 7, 2026

Uh oh!

Copilot AI Mar 7, 2026

Uh oh!

intel352 commented Mar 9, 2026

Uh oh!

Copilot AI commented Mar 9, 2026 •

edited

Loading

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

-		handler.SetEmptyResponsePolicy(EmptyResponsePolicy(routeConfig.EmptyPolicy))
+		switch routeConfig.EmptyPolicy {
+		case "allow-empty", "skip-empty", "fail-on-empty":
+			handler.SetEmptyResponsePolicy(EmptyResponsePolicy(routeConfig.EmptyPolicy))
+		default:
+			return nil, fmt.Errorf("invalid empty response policy %q for route %q: must be one of allow-empty, skip-empty, fail-on-empty", routeConfig.EmptyPolicy, routeConfig.Pattern)
+		}

Conversation

Copilot AI commented Mar 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Mar 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📋 API Contract Changes Summary

Changed Components:

Core Framework

Module: auth

Module: cache

Module: chimux

Module: database

Module: eventbus

Module: eventlogger

Module: httpclient

Module: httpserver

Module: jsonschema

Module: letsencrypt

Module: logmasker

Module: reverseproxy

Module: scheduler

Artifacts

Uh oh!

codecov bot commented Mar 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Mar 7, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 7, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 7, 2026

Choose a reason for hiding this comment

Uh oh!

intel352 commented Mar 9, 2026

Uh oh!

Copilot AI commented Mar 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Copilot AI commented Mar 6, 2026 •

edited

Loading

github-actions bot commented Mar 7, 2026 •

edited

Loading

codecov bot commented Mar 7, 2026 •

edited

Loading

Copilot AI commented Mar 9, 2026 •

edited

Loading