Improve structure and readability of boot time query#117
Open
socketz wants to merge 2 commits into
Open
Conversation
Refactor CQL to enhance clarity and organization of Windows OS boot time query.
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors the LogScale/CQL example query used to calculate Windows OS boot time and uptime from AgentOnline events, aiming to improve readability and organization.
Changes:
- Reordered/expanded steps in the query (added an explicit rounding step for
realBootTime). - Adjusted the aggregation to group by both
aidandComputerName. - Minor formatting cleanup within the markdown code block.
Comments suppressed due to low confidence (2)
Queries-Only/Helpful-CQL-Queries/Get Windows OS Boot Time.md:18
- This comment has a typo: "Crate" → "Create". Since this section explains the output structure, fixing it helps readability.
// Crate groupBy to organize output
| groupBy([aid, ComputerName], function=([selectLast([realBootTime,uptimeDays])]))
Queries-Only/Helpful-CQL-Queries/Get Windows OS Boot Time.md:18
- The PR description says this is a refactor for readability, but changing groupBy from aid-only to [aid, ComputerName] alters the result shape and can increase row count (e.g., if ComputerName changes over time for the same aid). If the goal is to show ComputerName without changing grouping semantics, consider keeping groupBy([aid]) and selecting the latest ComputerName inside selectLast/selectFromMax instead.
| groupBy([aid, ComputerName], function=([selectLast([realBootTime,uptimeDays])]))
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor CQL to enhance clarity and organization of Windows OS boot time query.