This repository was archived by the owner on Jun 24, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 0
DatabaseManager is able to access data from Firestore cloud. #7
Open
Kormaican
wants to merge
1
commit into
master
Choose a base branch
from
Firebase
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
30 changes: 30 additions & 0 deletions
30
app/src/main/java/crucentralcoast/database/DatabaseManager.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| package crucentralcoast.database | ||
|
|
||
| import android.graphics.BitmapFactory | ||
| import android.net.Uri | ||
| import android.widget.ImageView | ||
| import com.google.android.gms.tasks.Task | ||
| import com.google.firebase.firestore.* | ||
| import android.widget.TextView | ||
| import java.net.URI | ||
|
|
||
|
|
||
| data class DatabaseManager(val collectionName: String, | ||
| val db: FirebaseFirestore = FirebaseFirestore.getInstance()) | ||
| { | ||
|
|
||
| private val testDoc: String = "563b07402930ae0300fbc09b" | ||
|
|
||
| fun setText(textView: TextView) { | ||
| db.collection(collectionName).document(testDoc).get() | ||
| .addOnSuccessListener { | ||
| val tempStr = it.get("description") | ||
| if(tempStr is String) | ||
| textView.text = tempStr | ||
| else println("Value from Firestore is not of type String") | ||
| } | ||
| } | ||
|
|
||
|
|
||
|
|
||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a little fuzzy on what is going on in this function, especially in light of what is in the
MainActivity. It appears that this function gets a document from the collection then sets the textView's text to the description from the document. It seems like a lot of what is in this file is just proof of concept that you can get data from the DB. I'm however hesitant to accept it into the repo in that state. TheDatabaseManagershould just be reading and writing from the DB. We should probably have models for each item type such asEvent. Then in theMainActivityyou would have something likeAs a rule of thumb also avoid variable names like
tmpStrI'm fine with something being a temp variable, but tell me what it is temporarily storing (e.g.tmpDescription). Descriptive variable naming helps for a better comment/code sturcture. Your code should tell me "what" (in a pretty clear way) and your comments should tell me "why".Sorry about the length of this comment, I just want to make sure we get the data modeling set up well at the start since it is the core to the whole application.