MPDX-8678 - Improve AddDonation

[zweatshirt]

Description

Jira ticket

• Standardizes the AddDonation form, since many of the errors across fields were inconsistent.
• For consistency, I tried to make my changes relatively similar to the changes made in MPDX-8679

Checklist:

• I have given my PR a title with the format "MPDX-(JIRA#) (summary sentence max 80 chars)"
• I have applied the appropriate labels. (Add the label "On Staging" to get the branch automatically merged into staging.)
• I have requested a review from another person on the project

[github-actions]

Preview branch generated at https://MPDX-8678-improve-add-donation.d3dytjb8adxkk5.amplifyapp.com

[github-actions]

Bundle sizes [mpdx-react]

Compared against f62263d

No significant changes found

[wjames111]

Looks great! thanks for improving this form. The only issue I had was getting the DateField working.

[wjames111]

So right now we are essentially hacking the touched state by either leaving out the check for touched or forcing it to trigger on load onBlur={handleBlur('fieldValue')}. instead we could ensure Formik is properly updating the touched value by using formik's setFieldTouched.

 onChange={(_, value) => {
   setFieldValue('fieldValue', value);
   setFieldTouched('fieldValue', true, false);
}}
onBlur={() => {
  setFieldTouched('fieldValue', true);
}}

I think this is the best way to handle the form validation, it also works on the CustomDateField. CC @kegrimes

[zweatshirt]

So right now we are essentially hacking the touched state by either leaving out the check for touched or forcing it to trigger on load onBlur={handleBlur('fieldValue')}. instead we could ensure Formik is properly updating the touched value by using formik's setFieldTouched.

 onChange={(_, value) => {
   setFieldValue('fieldValue', value);
   setFieldTouched('fieldValue', true, false);
}}
onBlur={() => {
  setFieldTouched('fieldValue', true);
}}

I think this is the best way to handle the form validation, it also works on the CustomDateField. CC @kegrimes

@wjames111 Is this a change that should be made on all form fields or just the DateField one?

[wjames111]

@zweatshirt Ideally all of them if possible.