Conversation
Bundle sizes [mpdx-react]Compared against c360f7f
|
5ae68fc to
7693cd8
Compare
|
Preview branch generated at https://add-mutations-to-mha.d3dytjb8adxkk5.amplifyapp.com |
wjames111
left a comment
There was a problem hiding this comment.
Looks great, thanks for doing all this work! Found a few minor things but nothing serious.
src/components/Reports/MinisterHousingAllowance/EditRequest/EditRequestPage.test.tsx
Outdated
Show resolved
Hide resolved
src/components/Reports/MinisterHousingAllowance/EditRequest/EditRequestPage.test.tsx
Outdated
Show resolved
Hide resolved
src/components/Reports/MinisterHousingAllowance/EditRequest/EditRequestPage.tsx
Outdated
Show resolved
Hide resolved
src/components/Reports/MinisterHousingAllowance/MinisterHousingAllowance.graphql
Outdated
Show resolved
Hide resolved
src/components/Reports/Shared/CalculationReports/DirectionButtons/DirectionButtons.test.tsx
Outdated
Show resolved
Hide resolved
src/components/Reports/Shared/CalculationReports/DirectionButtons/DirectionButtons.test.tsx
Outdated
Show resolved
Hide resolved
src/components/Reports/Shared/CalculationReports/StatusCard/StatusCard.test.tsx
Outdated
Show resolved
Hide resolved
src/components/Reports/Shared/CalculationReports/StatusCard/StatusCard.tsx
Outdated
Show resolved
Hide resolved
dr-bizz
left a comment
There was a problem hiding this comment.
Sorry, I've been super busy with SIT functionality. I passed this to Will to review. Will will be in on Dec 29th, and you can ask him to review, so I'm not blocking you.
wjames111
left a comment
There was a problem hiding this comment.
These updates look great! I'm struggling to get it working locally for me though, not sure if I'm missing something.
src/components/Reports/MinisterHousingAllowance/SharedComponents/CurrentBoardApproved.tsx
Show resolved
Hide resolved
|
@wjames111 I am having trouble testing as well because I only have two requests that do not have the statuses I need in order to test. The first one is The current data I am talking about comes from |
wjames111
left a comment
There was a problem hiding this comment.
Thanks for making these changes, it looks great! I did notice last I checked there was a failing test. Also this may be a side affect of not being able to update the status but I noticed the create MHA button bugs out a little after an existing MHA is cancelled.
Screen.Recording.2026-01-05.at.9.53.54.AM.mov
...nts/Reports/MinisterHousingAllowance/Shared/Context/MinisterHousingAllowanceContext.test.tsx
Outdated
Show resolved
Hide resolved
src/components/Reports/MinisterHousingAllowance/Steps/StepThree/CalcComponents/CostOfHome.tsx
Show resolved
Hide resolved
src/components/Reports/MinisterHousingAllowance/Steps/StepThree/Calculation.tsx
Show resolved
Hide resolved
src/components/Reports/SalaryCalculator/EffectiveDateStep/useEffectiveDateOptions.ts
Show resolved
Hide resolved
src/components/Reports/SalaryCalculator/EffectiveDateStep/useEffectiveDateOptions.ts
Show resolved
Hide resolved
src/components/Reports/Shared/CalculationReports/PanelLayout/PanelLayout.tsx
Outdated
Show resolved
Hide resolved
src/components/Reports/Shared/CalculationReports/PanelLayout/PanelLayout.tsx
Outdated
Show resolved
Hide resolved
@canac do you have any thoughts on this? |
|
@wjames111 @kegrimes I'd probably update the database directly or use |
|
@dr-bizz Will has already reviewed some of this PR, but I added some mini updates to the MHA here. The process should now be very smooth in between each mutation. To test some changes, you may have to update Changing the View page and print functionality will be done in #1557. |
dr-bizz
left a comment
There was a problem hiding this comment.
Really great work on this!! I can tell you've worked really hard on this 🔥 💯
I spotted some things that needed adjusting, but no major issues.
When you complete the MHA, or when you click on print on the dashboard, it should take you to the view page, and automatically bring up the print popup, so the user doesn't need to click on print.
Also, when you are editing an MHA, then gon back to the dashboard, it gets stuck showing the skeletons. I think this was the issue I mentioned in the comments below about using loading.

src/components/Reports/MinisterHousingAllowance/MinisterHousingAllowance.tsx
Show resolved
Hide resolved
src/components/Reports/MinisterHousingAllowance/Steps/StepTwo/RentOwn.tsx
Show resolved
Hide resolved
src/components/Reports/MinisterHousingAllowance/SharedComponents/CurrentRequest.tsx
Outdated
Show resolved
Hide resolved
src/components/Reports/MinisterHousingAllowance/SharedComponents/CurrentRequest.tsx
Outdated
Show resolved
Hide resolved
src/components/Reports/MinisterHousingAllowance/SharedComponents/CurrentBoardApproved.tsx
Outdated
Show resolved
Hide resolved
src/components/Reports/MinisterHousingAllowance/SharedComponents/CurrentBoardApproved.tsx
Outdated
Show resolved
Hide resolved
6b46031 to
3fcffff
Compare
3fcffff to
9355bcc
Compare
wjames111
left a comment
There was a problem hiding this comment.
Looks great! Did a lot of work on this!
Description
Add graphQL delete, submit, and duplicate mutations to MHA. Also, updates UI based on new figma designs.
This PR also addresses these issues:
Note: Dialog for past deadline date, pending status, and permission denied components are under review by Ryan and stakeholders. (Edit: They have been approved)
Testing
/reports/housingAllowanceChecklist:
/pr-reviewcommand locally and fixed any relevant suggestions